Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1938613003: Subtract instead of adding the negation. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Subtract instead of adding the negation. Do more cleanup in modified files. Committed: https://pdfium.googlesource.com/pdfium/+/8c32dfa88b9deedb5add135301a0f6b1128882ed

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -73 lines) Patch
M core/fpdfdoc/doc_vt.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 6 chunks +63 lines, -64 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-04-29 21:18:34 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1938613003/diff/1/core/fpdfdoc/doc_vt.cpp File core/fpdfdoc/doc_vt.cpp (right): https://codereview.chromium.org/1938613003/diff/1/core/fpdfdoc/doc_vt.cpp#newcode691 core/fpdfdoc/doc_vt.cpp:691: fMaxY += (m_pVT->GetLineLeading(m_pSection->m_SecInfo) + fLineAscent - nit: overparenthesized.
4 years, 7 months ago (2016-04-29 22:32:41 UTC) #3
Lei Zhang
https://codereview.chromium.org/1938613003/diff/1/core/fpdfdoc/doc_vt.cpp File core/fpdfdoc/doc_vt.cpp (right): https://codereview.chromium.org/1938613003/diff/1/core/fpdfdoc/doc_vt.cpp#newcode691 core/fpdfdoc/doc_vt.cpp:691: fMaxY += (m_pVT->GetLineLeading(m_pSection->m_SecInfo) + fLineAscent - On 2016/04/29 22:32:41, ...
4 years, 7 months ago (2016-04-30 01:01:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938613003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938613003/20001
4 years, 7 months ago (2016-04-30 01:01:32 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 01:14:43 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8c32dfa88b9deedb5add135301a0f6b11288...

Powered by Google App Engine
This is Rietveld 408576698