Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: Source/core/svg/SVGTransform.cpp

Issue 19386002: Get rid of special casing for SVGTransform.matrix from the bindings generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGTransform.h ('k') | Source/core/svg/SVGTransform.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 { 52 {
53 } 53 }
54 54
55 void SVGTransform::setMatrix(const AffineTransform& matrix) 55 void SVGTransform::setMatrix(const AffineTransform& matrix)
56 { 56 {
57 m_type = SVG_TRANSFORM_MATRIX; 57 m_type = SVG_TRANSFORM_MATRIX;
58 m_angle = 0; 58 m_angle = 0;
59 m_matrix = matrix; 59 m_matrix = matrix;
60 } 60 }
61 61
62 void SVGTransform::updateMatrix() 62 void SVGTransform::updateSvgMatrix()
haraken 2013/07/16 14:29:39 Is there any caller of updateSvgMatrix()? If no, w
do-not-use 2013/07/16 14:33:10 Yes, it is called by the generated code. This is w
63 { 63 {
64 // The underlying matrix has been changed, alter the transformation type. 64 // The underlying matrix has been changed, alter the transformation type.
65 // Spec: In case the matrix object is changed directly (i.e., without using the methods on the SVGTransform interface itself) 65 // Spec: In case the matrix object is changed directly (i.e., without using the methods on the SVGTransform interface itself)
66 // then the type of the SVGTransform changes to SVG_TRANSFORM_MATRIX. 66 // then the type of the SVGTransform changes to SVG_TRANSFORM_MATRIX.
67 m_type = SVG_TRANSFORM_MATRIX; 67 m_type = SVG_TRANSFORM_MATRIX;
68 m_angle = 0; 68 m_angle = 0;
69 } 69 }
70 70
71 void SVGTransform::setTranslate(float tx, float ty) 71 void SVGTransform::setTranslate(float tx, float ty)
72 { 72 {
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 return prefix + String::number(m_angle) + ')'; 193 return prefix + String::number(m_angle) + ')';
194 case SVG_TRANSFORM_SKEWY: 194 case SVG_TRANSFORM_SKEWY:
195 return prefix + String::number(m_angle) + ')'; 195 return prefix + String::number(m_angle) + ')';
196 } 196 }
197 197
198 ASSERT_NOT_REACHED(); 198 ASSERT_NOT_REACHED();
199 return emptyString(); 199 return emptyString();
200 } 200 }
201 201
202 } // namespace WebCore 202 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/svg/SVGTransform.h ('k') | Source/core/svg/SVGTransform.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698