Issue 19386002: Get rid of special casing for SVGTransform.matrix from the bindings generator

Issue 19386002: Get rid of special casing for SVGTransform.matrix from the bindings generator (Closed)

Created:
7 years, 5 months ago by do-not-use

Modified:
7 years, 5 months ago

Reviewers:
haraken, Stephen Chennney

CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, pdr, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, haraken, Stephen Chennney, Nate Chapin, do-not-use, lgombos, krit

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Get rid of special casing for SVGTransform.matrix from the bindings generator Get rid of special casing for SVGTransform.matrix from the bindings generator by using [ImplementedAs=svgMatrix] for that attribute. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154303

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -9 lines)			Patch
M	Source/bindings/scripts/deprecated_code_generator_v8.pm	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/svg/SVGTransform.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGTransform.cpp	View	1 chunk	+1 line, -1 line	2 comments	Download
M	Source/core/svg/SVGTransform.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/19386002/diff/1/Source/core/svg/SVGTransform.cpp File Source/core/svg/SVGTransform.cpp (right): https://codereview.chromium.org/19386002/diff/1/Source/core/svg/SVGTransform.cpp#newcode62 Source/core/svg/SVGTransform.cpp:62: void SVGTransform::updateSvgMatrix() Is there any caller of updateSvgMatrix()? ...

7 years, 5 months ago (2013-07-16 14:29:38 UTC) #2

do-not-use

https://codereview.chromium.org/19386002/diff/1/Source/core/svg/SVGTransform.cpp File Source/core/svg/SVGTransform.cpp (right): https://codereview.chromium.org/19386002/diff/1/Source/core/svg/SVGTransform.cpp#newcode62 Source/core/svg/SVGTransform.cpp:62: void SVGTransform::updateSvgMatrix() On 2013/07/16 14:29:39, haraken wrote: > > ...

7 years, 5 months ago (2013-07-16 14:33:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19386002/1

7 years, 5 months ago (2013-07-16 14:36:32 UTC) #4

Message was sent while issue was closed.

Change committed as 154303

Expand Messages | Collapse Messages