Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: runtime/vm/compiler.cc

Issue 1938553002: Give OSR compilation its own event name. Rename other optimization compilation events so they sort … (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index 4e7fc1cce9516e0123200ffb0fd2ad0d149aa435..49796c15a63b4624264e3f4f495f11ddf18509a1 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -1444,9 +1444,14 @@ RawError* Compiler::CompileOptimizedFunction(Thread* thread,
intptr_t osr_id) {
NOT_IN_PRODUCT(
VMTagScope tagScope(thread, VMTag::kCompileOptimizedTagId);
- const char* event_name = IsBackgroundCompilation()
- ? "BackgroundCompileOptimizedFunction"
- : "CompileOptimizedFunction";
+ const char* event_name;
+ if (osr_id != kNoOSRDeoptId) {
+ event_name = "CompileFunctionOptimizedOSR";
+ } else if (IsBackgroundCompilation()) {
+ event_name = "CompileFunctionOptimizedBackground";
+ } else {
+ event_name = "CompileFunctionOptimized";
+ }
TIMELINE_FUNCTION_COMPILATION_DURATION(thread, event_name, function);
) // !PRODUCT
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698