Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1938533002: Convert track-language* and track-large* tests to testharness.js (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track-language* and track-large* tests to testharness.js Cleaning up track-language* and track-large* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/f43cd3e41312f5edbcdcd703fcc24f5ea63a223a Cr-Commit-Position: refs/heads/master@{#391588}

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comments #

Messages

Total messages: 16 (7 generated)
Srirama
PTAL
4 years, 7 months ago (2016-04-29 19:08:31 UTC) #3
ddorwin
OOC, is there a reason this isn't combined with https://codereview.chromium.org/1937483002/? Please at least indicate the ...
4 years, 7 months ago (2016-04-29 21:47:48 UTC) #4
Srirama
On 2016/04/29 21:47:48, ddorwin wrote: > OOC, is there a reason this isn't combined with ...
4 years, 7 months ago (2016-04-30 03:24:16 UTC) #5
ddorwin
On 2016/04/30 03:24:16, Srirama wrote: > On 2016/04/29 21:47:48, ddorwin wrote: > > OOC, is ...
4 years, 7 months ago (2016-04-30 18:55:22 UTC) #6
Srirama
On 2016/04/30 18:55:22, ddorwin wrote: > On 2016/04/30 03:24:16, Srirama wrote: > > On 2016/04/29 ...
4 years, 7 months ago (2016-05-01 11:26:08 UTC) #7
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/1938533002/diff/1/third_party/WebKit/LayoutTests/media/track/track-language-preference.html File third_party/WebKit/LayoutTests/media/track/track-language-preference.html (right): https://codereview.chromium.org/1938533002/diff/1/third_party/WebKit/LayoutTests/media/track/track-language-preference.html#newcode37 third_party/WebKit/LayoutTests/media/track/track-language-preference.html:37: expectedLanguage : "es-MX" Interesting. https://codereview.chromium.org/1938533002/diff/1/third_party/WebKit/LayoutTests/media/track/track-language-preference.html#newcode80 third_party/WebKit/LayoutTests/media/track/track-language-preference.html:80: track = ...
4 years, 7 months ago (2016-05-04 14:11:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938533002/20001
4 years, 7 months ago (2016-05-04 17:57:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 19:01:34 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 19:03:59 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f43cd3e41312f5edbcdcd703fcc24f5ea63a223a
Cr-Commit-Position: refs/heads/master@{#391588}

Powered by Google App Engine
This is Rietveld 408576698