Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1938473002: Rename gfx::Display/Screen to display::Display/Screen in chrome/content/extensions mac (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tapted, Matt Giuca, extensions-reviews_chromium.org, tfarina, jam, nona+watch_chromium.org, darin-cc_chromium.org, shuchen+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in chrome/content mac BUG=597761 Committed: https://crrev.com/e8300135a2525ef91c5a5f1bbbb100eb789bd46a Cr-Commit-Position: refs/heads/master@{#390785}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M chrome/browser/ui/app_list/app_list_service_mac.mm View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 7 chunks +15 lines, -15 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938473002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938473002/100001
4 years, 7 months ago (2016-04-29 18:39:35 UTC) #5
oshima
asvitkine@ -> content/browser/renderer_host, chrome/browser/ui/cocoa jennyz@ -> chrome/browser/ui/app_list jamescook@ -> extensions/shell
4 years, 7 months ago (2016-04-29 18:53:00 UTC) #9
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-04-29 18:56:41 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 19:28:16 UTC) #12
James Cook
extensions/shell lgtm
4 years, 7 months ago (2016-04-29 20:34:54 UTC) #13
jennyz
lgtm
4 years, 7 months ago (2016-04-29 22:25:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938473002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938473002/100001
4 years, 7 months ago (2016-04-29 22:29:31 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:100001)
4 years, 7 months ago (2016-04-29 22:34:27 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:29:40 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e8300135a2525ef91c5a5f1bbbb100eb789bd46a
Cr-Commit-Position: refs/heads/master@{#390785}

Powered by Google App Engine
This is Rietveld 408576698