Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 1938443002: Allow muted third-party autoplay with -ormuted experiment option. (Closed)

Created:
4 years, 7 months ago by liberato (no reviews please)
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow muted third-party autoplay with -ormuted experiment option. If -ifsameorigin is enabled, allow -ormuted to allow muted cross-orign playback. If the media is later unmuted during autoplay, then playback will pause if no user gesture is available. BUG=599695 Committed: https://crrev.com/6607760a92452e4a9ae0e54620839b5f98b44c20 Cr-Commit-Position: refs/heads/master@{#394608}

Patch Set 1 #

Patch Set 2 : fixes for "don't unlock" semantics of the experiment. #

Patch Set 3 : removed debug. #

Patch Set 4 : removed unused flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp View 1 2 3 3 chunks +38 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp View 1 2 chunks +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
liberato (no reviews please)
4 years, 7 months ago (2016-05-17 21:41:16 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years, 7 months ago (2016-05-18 10:42:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938443002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938443002/60001
4 years, 7 months ago (2016-05-18 22:08:59 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-18 23:57:06 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 23:59:01 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6607760a92452e4a9ae0e54620839b5f98b44c20
Cr-Commit-Position: refs/heads/master@{#394608}

Powered by Google App Engine
This is Rietveld 408576698