Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1938403003: Use property accessor elements for type inference rather than field elements. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use property accessor elements for type inference rather than field elements. This makes the behavior of the linker more consistent with the language spec. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/243e44074ca5afaf9799e3bf35a1ca10cd5e182d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -42 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 11 chunks +49 lines, -42 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-03 21:31:42 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-03 21:33:36 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-03 21:50:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
243e44074ca5afaf9799e3bf35a1ca10cd5e182d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698