Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1938383002: [turbofan] Properly hook up string operators in the effect/control chain. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly hook up string operators in the effect/control chain. The string operators not only read memory, but also write memory in case of cons string flattening, so we better make sure to have the stub calls in the effect chain. R=jarin@chromium.org Committed: https://crrev.com/79688584f099d6619aeb33f68da7a589e22acebb Cr-Commit-Position: refs/heads/master@{#35965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M src/compiler/simplified-lowering.cc View 8 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-03 08:07:51 UTC) #1
Benedikt Meurer
Hey Jaro, Quick fix for the stirng oeprators. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-03 08:09:51 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-03 08:12:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938383002/1
4 years, 7 months ago (2016-05-03 08:25:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 08:35:12 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 08:35:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79688584f099d6619aeb33f68da7a589e22acebb
Cr-Commit-Position: refs/heads/master@{#35965}

Powered by Google App Engine
This is Rietveld 408576698