third_party/WebKit/Source/core/core_generated.gyp - Issue 1938343002: Generate a series of nested switch statements to parse CSSPrimitiveValue units.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/core_generated.gyp

Issue 1938343002: Generate a series of nested switch statements to parse CSSPrimitiveValue units. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make all values appear in the .in file Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/templates/macros.tmpl ('K') | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/core_generated.gypi » ('j') | third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/core_generated.gyp

diff --git a/third_party/WebKit/Source/core/core_generated.gyp b/third_party/WebKit/Source/core/core_generated.gyp

index 8f4d6fc446f4c4c1fb7a3b37669981ea480fd5bf..17e9e2e1b733de665aa72e7e570af17cc00fbd8d 100644

--- a/third_party/WebKit/Source/core/core_generated.gyp

+++ b/third_party/WebKit/Source/core/core_generated.gyp

@@ -730,9 +730,28 @@

{

+ 'action_name': 'CSSPrimitiveValueUnitTrie',

+ 'inputs': [

+ '<@(make_trie_helpers_files)',

+ '../build/scripts/make_css_primitive_value_unit_trie.py',

+ '../build/scripts/templates/CSSPrimitiveValueUnitTrie.cpp.tmpl',

+ 'css/CSSPrimitiveValueUnits.in',

+ ],

+ 'outputs': [

+ '<(blink_core_output_dir)/CSSPrimitiveValueUnitTrie.cpp',

+ ],

+ 'action': [

+ 'python',

+ '../build/scripts/make_css_primitive_value_unit_trie.py',

+ 'css/CSSPrimitiveValueUnits.in',

+ '--output_dir',

+ '<(blink_core_output_dir)',

+ ],

+ },

+ {

'action_name': 'HTMLElementLookupTrie',

'inputs': [

- '<@(scripts_for_in_files)',

+ '<@(make_trie_helpers_files)',

'../build/scripts/make_element_lookup_trie.py',

'../build/scripts/templates/ElementLookupTrie.cpp.tmpl',

'../build/scripts/templates/ElementLookupTrie.h.tmpl',