Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 1938343002: Generate a series of nested switch statements to parse CSSPrimitiveValue units. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 3ece896d5b1d88ae5190130c2cd272fcad8d4532..1c16226e175e5be7d100550e125ce3bae4667b2d 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -352,6 +352,7 @@ source_set("core_generated") {
"$blink_core_output_dir/CSSValueKeywords.cpp",
# Additional .cpp files from make_core_generated actions.
+ "$blink_core_output_dir/CSSPrimitiveValueUnitTrie.cpp",
"$blink_core_output_dir/Event.cpp",
"$blink_core_output_dir/EventHeaders.h",
"$blink_core_output_dir/EventNames.cpp",
@@ -565,6 +566,7 @@ action("generated_testing_idls_internal_runtime_flags") {
group("make_core_generated") {
public_deps = [
":make_core_generated_bison",
+ ":make_core_generated_css_primitive_value_unit_trie",
":make_core_generated_css_property_metadata",
":make_core_generated_css_property_names",
":make_core_generated_css_tokenizer_codepoints",
@@ -970,6 +972,30 @@ action("make_core_generated_css_tokenizer_codepoints") {
deps = make_core_generated_deps
}
+# "CSSPrimitiveValueUnitTrie" in make_core_generated from GYP.
+action("make_core_generated_css_primitive_value_unit_trie") {
+ visibility = [] # Allow re-assignment of list.
+ visibility = [ ":make_core_generated" ]
+ script = "../build/scripts/make_css_primitive_value_unit_trie.py"
+
+ input_file = "css/CSSPrimitiveValueUnits.in"
+ inputs = scripts_for_in_files + [
+ input_file,
+ "../build/scripts/templates/CSSPrimitiveValueUnitTrie.cpp.tmpl",
+ ]
+ outputs = [
+ "$blink_core_output_dir/CSSPrimitiveValueUnitTrie.cpp",
+ ]
+
+ args = [
+ rebase_path(input_file, root_build_dir),
+ "--output_dir",
+ rel_blink_core_gen_dir,
+ ]
+
+ deps = make_core_generated_deps
+}
+
# "HTMLElementLookupTrie" in make_core_generated from GYP.
action("make_core_generated_html_element_lookup_trie") {
visibility = [] # Allow re-assignment of list.

Powered by Google App Engine
This is Rietveld 408576698