third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.in - Issue 1938343002: Generate a series of nested switch statements to parse CSSPrimitiveValue units.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.in

Issue 1938343002: Generate a series of nested switch statements to parse CSSPrimitiveValue units. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/css/CSSPrimitiveValueUnitTrie.h ('K') | « third_party/WebKit/Source/core/css/CSSPrimitiveValueUnitTrie.h ('k') | third_party/WebKit/Source/core/css/cssom/LengthValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // This file specifies the unit strings used in CSSPrimitiveValues.

	2

	3 em unit_type=Ems

	4 ex unit_type=Exs

	5 px unit_type=Pixels

	6 cm unit_type=Centimeters

	7 mm unit_type=Millimeters

	8 in unit_type=Inches

	9 pt unit_type=Points

	10 pc unit_type=Picas

	11 "" unit_type=UserUnits
	Timothy Loh 2016/05/03 07:40:26 let's just hard-code this in CSSPrimitiveValueUnit let's just hard-code this in CSSPrimitiveValueUnitTrie.cpp.tmpl instead of putting it in this file meade_UTC10 2016/05/04 07:24:54 Done. Show quoted text On 2016/05/03 07:40:26, Timothy Loh wrote: > let's just hard-code this in CSSPrimitiveValueUnitTrie.cpp.tmpl instead of > putting it in this file Done.
	12 deg unit_type=Degrees

	13 rad unit_type=Radians

	14 grad unit_type=Gradians

	15 ms unit_type=Milliseconds

	16 s unit_type=Seconds

	17 hz unit_type=Hertz

	18 khz unit_type=Kilohertz

	19 dpi unit_type=DotsPerInch

	20 dpcm unit_type=DotsPerCentimeter

	21 dppx unit_type=DotsPerPixel

	22 vw unit_type=ViewportWidth

	23 vh unit_type=ViewportHeight

	24 vmin unit_type=ViewportMin

	25 vmax unit_type=ViewportMax

	26 rem unit_type=Rems

	27 fr unit_type=Fraction

	28 turn unit_type=Turns

	29 ch unit_type=Chs

	30 __qem unit_type=QuirkyEms

	31

OLD	NEW