Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 1938313002: DevTools: [SASS] parse SCSS rules and their selectors. (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SASS] parse SCSS rules and their selectors. This patch teaches SCSS parser to extract rules array. For example, given the following SCSS: $color: red; .message { border: 1px solid black; .title { color: #333; } } The SCSS parser will extract three rules, with all top-level declarations contained by the first rule without any selectors. { $color: red; } .message { border: 1px solid black; } .title { color: #333; } BUG=608097 R=pfeldman Committed: https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9 Cr-Commit-Position: refs/heads/master@{#391383}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Messages

Total messages: 15 (7 generated)
lushnikov
ptal
4 years, 7 months ago (2016-05-03 01:08:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938313002/1
4 years, 7 months ago (2016-05-03 01:09:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 02:15:48 UTC) #6
pfeldman
lgtm https://codereview.chromium.org/1938313002/diff/1/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js File third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js (right): https://codereview.chromium.org/1938313002/diff/1/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js#newcode28 third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js:28: var rootBlock = { Please annotate. https://codereview.chromium.org/1938313002/diff/1/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js#newcode32 third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js:32: ...
4 years, 7 months ago (2016-05-03 17:55:46 UTC) #7
lushnikov
https://codereview.chromium.org/1938313002/diff/1/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js File third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js (right): https://codereview.chromium.org/1938313002/diff/1/third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js#newcode28 third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js:28: var rootBlock = { On 2016/05/03 17:55:46, pfeldman wrote: ...
4 years, 7 months ago (2016-05-03 20:51:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938313002/20001
4 years, 7 months ago (2016-05-03 20:52:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 23:00:29 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 23:02:13 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a14461fedcb35dda8aed002ffa971479d15892b9
Cr-Commit-Position: refs/heads/master@{#391383}

Powered by Google App Engine
This is Rietveld 408576698