Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1938263002: Get media_blink_unittests running on Android (Closed)

Created:
4 years, 7 months ago by watk
Modified:
4 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jbudorick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get media_blink_unittests running on Android media_blink_unittests wasn't running for a couple of reasons: 1) the v8 snapshots were not being bundled in the apk, 2) it was missing a dep on //media/base/android:media_java so it would fail to find media classes. BUG=608084 Committed: https://crrev.com/23fff35c8f6011affb8c3025b5e4ec3e82c13bb0 Cr-Commit-Position: refs/heads/master@{#391152}

Patch Set 1 #

Patch Set 2 : clean up comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M media/blink/BUILD.gn View 2 chunks +9 lines, -4 lines 0 comments Download
M media/blink/run_all_unittests.cc View 1 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
watk
4 years, 7 months ago (2016-05-02 23:13:52 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 7 months ago (2016-05-02 23:23:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938263002/40001
4 years, 7 months ago (2016-05-02 23:25:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-03 01:40:22 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 01:41:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23fff35c8f6011affb8c3025b5e4ec3e82c13bb0
Cr-Commit-Position: refs/heads/master@{#391152}

Powered by Google App Engine
This is Rietveld 408576698