Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1938183003: Security panel: add listeners only to the added target. (Closed)

Created:
4 years, 7 months ago by lgarron
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Security panel: add listeners only to the added target. This prevents the Security panel from getting MainFrameNavigated events from service workers. BUG=608113 TEST=1. Open the native new tab page. 2. Open the DevTools Security panel. 3. Refresh 4. Wait a few seconds The sidebar of the Security panel should show at least three sections (Main Origin, Non-Secure Origins, Secure Origins), and those sections should *not disappear*. Committed: https://crrev.com/c9bfaecea4885f2dd2ba60796e998f1fb5e5d3e7 Cr-Commit-Position: refs/heads/master@{#391142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 3 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
lgarron
pfeldman@, could you review?
4 years, 7 months ago (2016-05-02 23:23:07 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-02 23:31:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938183003/1
4 years, 7 months ago (2016-05-03 00:03:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 01:26:21 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 01:27:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9bfaecea4885f2dd2ba60796e998f1fb5e5d3e7
Cr-Commit-Position: refs/heads/master@{#391142}

Powered by Google App Engine
This is Rietveld 408576698