Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: xfa/fxfa/parser/xfa_script_eventpseudomodel.h

Issue 1938163002: More define cleanup. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fxfa/parser/xfa_script_eventpseudomodel.h
diff --git a/xfa/fxfa/parser/xfa_script_eventpseudomodel.h b/xfa/fxfa/parser/xfa_script_eventpseudomodel.h
index f2a11357cb6c27186fc698c14581b89bd20eea0b..2b206719a705acdfa1e7ba6834fde4c95b791bd8 100644
--- a/xfa/fxfa/parser/xfa_script_eventpseudomodel.h
+++ b/xfa/fxfa/parser/xfa_script_eventpseudomodel.h
@@ -10,23 +10,25 @@
#include "xfa/fxfa/parser/xfa_object.h"
#include "xfa/fxjse/cfxjse_arguments.h"
-#define XFA_EVENT_CHANGE 0
-#define XFA_EVENT_COMMITKEY 1
-#define XFA_EVENT_FULLTEXT 2
-#define XFA_EVENT_KEYDOWN 3
-#define XFA_EVENT_MODIFIER 4
-#define XFA_EVENT_NEWCONTENTTYPE 5
-#define XFA_EVENT_NEWTEXT 6
-#define XFA_EVENT_PREVCONTENTTYPE 7
-#define XFA_EVENT_PREVTEXT 8
-#define XFA_EVENT_REENTER 9
-#define XFA_EVENT_SELEND 10
-#define XFA_EVENT_SELSTART 11
-#define XFA_EVENT_SHIFT 12
-#define XFA_EVENT_SOAPFAULTCODE 13
-#define XFA_EVENT_SOAPFAULTSTRING 14
-#define XFA_EVENT_TARGET 15
-#define XFA_EVENT_CANCELACTION 16
+enum class XFA_Event {
+ Change = 0,
+ CommitKey = 1,
Tom Sepez 2016/05/02 21:45:39 Subsequent initializers not needed, and you run th
dsinclair 2016/05/03 13:58:16 Done.
+ FullText = 2,
+ Keydown = 3,
+ Modifier = 4,
+ NewContentType = 5,
+ NewText = 6,
+ PreviousContentType = 7,
+ PreviousText = 8,
+ Reenter = 9,
+ SelectionEnd = 10,
+ SelectionStart = 11,
+ Shift = 12,
+ SoapFaultCode = 13,
+ SoapFaultString = 14,
+ Target = 15,
+ CancelAction = 16
+};
class CScript_EventPseudoModel : public CXFA_OrdinaryObject {
public:
@@ -87,7 +89,7 @@ class CScript_EventPseudoModel : public CXFA_OrdinaryObject {
protected:
void Script_EventPseudoModel_Property(FXJSE_HVALUE hValue,
- uint32_t dwFlag,
+ XFA_Event dwFlag,
FX_BOOL bSetting);
};

Powered by Google App Engine
This is Rietveld 408576698