Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: extensions/renderer/utils_native_handler.cc

Issue 1938123002: Ensure that privates are private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/utils_native_handler.h ('k') | extensions/test/data/utils_unittest.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/utils_native_handler.h" 5 #include "extensions/renderer/utils_native_handler.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/stringprintf.h"
9 #include "extensions/renderer/script_context.h" 8 #include "extensions/renderer/script_context.h"
10 #include "third_party/WebKit/public/web/WebSerializedScriptValue.h" 9 #include "third_party/WebKit/public/web/WebSerializedScriptValue.h"
11 10
12 namespace extensions { 11 namespace extensions {
13 12
14 UtilsNativeHandler::UtilsNativeHandler(ScriptContext* context) 13 UtilsNativeHandler::UtilsNativeHandler(ScriptContext* context)
15 : ObjectBackedNativeHandler(context) { 14 : ObjectBackedNativeHandler(context) {
16 RouteFunction("createClassWrapper",
17 base::Bind(&UtilsNativeHandler::CreateClassWrapper,
18 base::Unretained(this)));
19 RouteFunction( 15 RouteFunction(
20 "deepCopy", 16 "deepCopy",
21 base::Bind(&UtilsNativeHandler::DeepCopy, base::Unretained(this))); 17 base::Bind(&UtilsNativeHandler::DeepCopy, base::Unretained(this)));
22 } 18 }
23 19
24 UtilsNativeHandler::~UtilsNativeHandler() {} 20 UtilsNativeHandler::~UtilsNativeHandler() {}
25 21
26 void UtilsNativeHandler::CreateClassWrapper(
27 const v8::FunctionCallbackInfo<v8::Value>& args) {
28 CHECK_EQ(3, args.Length());
29 CHECK(args[0]->IsString());
30 std::string name = *v8::String::Utf8Value(args[0]);
31 CHECK(args[1]->IsObject());
32 v8::Local<v8::Object> cls = args[1].As<v8::Object>();
33 CHECK(args[2]->IsObject() || args[2]->IsUndefined());
34 v8::Local<v8::Value> superclass = args[2];
35
36 v8::HandleScope handle_scope(GetIsolate());
37 // TODO(fsamuel): Consider moving the source wrapping to ModuleSystem.
38 v8::Local<v8::String> source = v8::String::NewFromUtf8(
39 GetIsolate(),
40 base::StringPrintf(
41 "(function($Object, $Function, privates, cls, superclass) {"
42 "'use strict';\n"
43 " function %s() {\n"
44 " var privateObj = $Object.create(cls.prototype);\n"
45 " $Function.apply(cls, privateObj, arguments);\n"
46 " privateObj.wrapper = this;\n"
47 " privates(this).impl = privateObj;\n"
48 " };\n"
49 " if (superclass) {\n"
50 " %s.prototype = Object.create(superclass.prototype);\n"
51 " }\n"
52 " return %s;\n"
53 "})",
54 name.c_str(), name.c_str(), name.c_str()).c_str());
55 v8::Local<v8::Value> func_as_value = context()->module_system()->RunString(
56 source, v8::String::NewFromUtf8(GetIsolate(), name.c_str()));
57 if (func_as_value.IsEmpty() || func_as_value->IsUndefined()) {
58 args.GetReturnValue().SetUndefined();
59 return;
60 }
61
62 // TODO(fsamuel): Move privates from ModuleSystem to a shared location.
63 v8::Local<v8::Object> natives(context()->module_system()->NewInstance());
64 CHECK(!natives.IsEmpty()); // this can happen if v8 has issues
65
66 v8::Local<v8::Function> func = func_as_value.As<v8::Function>();
67 v8::Local<v8::Value> func_args[] = {
68 context()->safe_builtins()->GetObjekt(),
69 context()->safe_builtins()->GetFunction(),
70 natives->Get(v8::String::NewFromUtf8(GetIsolate(), "privates",
71 v8::String::kInternalizedString)),
72 cls,
73 superclass};
74 v8::Local<v8::Value> result;
75 {
76 v8::TryCatch try_catch(GetIsolate());
77 try_catch.SetCaptureMessage(true);
78 result = context()->CallFunction(func, arraysize(func_args), func_args);
79 if (try_catch.HasCaught()) {
80 args.GetReturnValue().SetUndefined();
81 return;
82 }
83 }
84 args.GetReturnValue().Set(result);
85 }
86
87 void UtilsNativeHandler::DeepCopy( 22 void UtilsNativeHandler::DeepCopy(
88 const v8::FunctionCallbackInfo<v8::Value>& args) { 23 const v8::FunctionCallbackInfo<v8::Value>& args) {
89 CHECK_EQ(1, args.Length()); 24 CHECK_EQ(1, args.Length());
90 args.GetReturnValue().Set( 25 args.GetReturnValue().Set(
91 blink::WebSerializedScriptValue::serialize(args[0]).deserialize()); 26 blink::WebSerializedScriptValue::serialize(args[0]).deserialize());
92 } 27 }
93 28
94 } // namespace extensions 29 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/utils_native_handler.h ('k') | extensions/test/data/utils_unittest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698