Sync media/gpu gyp and gn Mac framework deps (copy gyp => gn)

Sync media/gpu gyp and gn Mac framework deps (copy gyp => gn)

BUG=608816
Committed: https://crrev.com/406527c97434a63dea38c3b77024f8dde2765c34
Cr-Commit-Position: refs/heads/master@{#391598}

[Mark Dittmer, 2016-05-02 20:02:10]

Description was changed from

==========
Drop unnecessary Mac frameworks from media/gpu

BUG=586386
==========

to

==========
Drop unnecessary Mac frameworks from media/gpu

BUG=586386
==========

[Mark Dittmer, 2016-05-02 20:02:10]

markdittmer@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[Mark Dittmer, 2016-05-02 20:03:20]

This commented-out configuration should have been omitted in the original move
CL (content/common/media/gpu => media/gpu), but it got forgotten in the face of
more salient issues.

[Mark Dittmer, 2016-05-02 20:03:35]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 20:03:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938113002/1

[DaleCurtis, 2016-05-02 20:50:24]

dalecurtis@chromium.org changed reviewers:
+ sandersd@chromium.org

[DaleCurtis, 2016-05-02 20:50:24]

=>sandersd

[sandersd (OOO until July 31), 2016-05-02 21:07:41]

At the very least, this list should be the same as the gyp version (which
currently adds OpenGL to the list). I'm not certain that removing both is
correct either, the build may be depending on transitive dependencies in that
case.

We're currently waiting for issue 580152 so that we can delete the glue layers
(eg. vt_stubs), after which we will directly depend on the VideoToolbox
framework as well. Perhaps we should put off cleaning this until that settles?

[commit-bot: I haz the power, 2016-05-02 21:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 21:29:40]

Dry run: This issue passed the CQ dry run.

[Mark Dittmer, 2016-05-03 17:36:01]

On 2016/05/02 21:07:41, sandersd wrote:
> At the very least, this list should be the same as the gyp version (which
> currently adds OpenGL to the list). I'm not certain that removing both is
> correct either, the build may be depending on transitive dependencies in that
> case.
> 
> We're currently waiting for issue 580152 so that we can delete the glue layers
> (eg. vt_stubs), after which we will directly depend on the VideoToolbox
> framework as well. Perhaps we should put off cleaning this until that settles?

SGTM.

[Mark Dittmer, 2016-05-03 17:41:35]

Description was changed from

==========
Drop unnecessary Mac frameworks from media/gpu

BUG=586386
==========

to

==========
Drop unnecessary Mac frameworks from media/gpu

BUG=608816
==========

[erikchen, 2016-05-03 19:19:06]

On 2016/05/02 21:07:41, sandersd wrote:
> At the very least, this list should be the same as the gyp version (which
> currently adds OpenGL to the list). I'm not certain that removing both is
> correct either, the build may be depending on transitive dependencies in that
> case.
> 
> We're currently waiting for issue 580152 so that we can delete the glue layers
> (eg. vt_stubs), after which we will directly depend on the VideoToolbox
> framework as well. Perhaps we should put off cleaning this until that settles?

Issue 580152 shouldn't be blocking any code removal. 

We don't run Chrome on 10.8 or older any more, and we link against the 10.10
SDK, so there shouldn't be anything that prevents you from dropping unnecessary
Mac frameworks.

I've also posted here:
https://bugs.chromium.org/p/chromium/issues/detail?id=579648

[Mark Dittmer, 2016-05-03 19:32:14]

WIP: DO NOT COMMIT: Mask out frameworks copied over from content to see what
errors arise

[Mark Dittmer, 2016-05-03 20:14:59]

As my CL shows, I've tried to use Macs (now locally, in addition to failed
trybot attempt) to remove libs deps so that the compiler can tell me which ones
are actually used by this component. Unfortunately, it appears that gn will tell
me all the libs that I depend on, but It won't let me exclude ones that I depend
on directly.

Is there a systematic way to determine which Mac-related libs my source depends
on directly?

[Mark Dittmer, 2016-05-03 20:16:26]

On 2016/05/03 20:14:59, Mark Dittmer wrote:
> As my CL shows, I've tried to use Macs (now locally, in addition to failed
> trybot attempt) to remove libs deps so that the compiler can tell me which
ones
> are actually used by this component. Unfortunately, it appears that gn will
tell
> me all the libs that I depend on, but It won't let me exclude ones that I
depend
> on directly.
> 
> Is there a systematic way to determine which Mac-related libs my source
depends
> on directly?

Also, clarification: There are a bunch of frameworks pulled in by the gyp build
[1]. However, I'm not convinced that they're all needed; the list was copied
over from content_common.

Should be, for now, updating the list in gn to match (even though they may not
all be needed?

[Mark Dittmer, 2016-05-03 20:18:04]

On 2016/05/03 20:16:26, Mark Dittmer wrote:
> On 2016/05/03 20:14:59, Mark Dittmer wrote:
> > As my CL shows, I've tried to use Macs (now locally, in addition to failed
> > trybot attempt) to remove libs deps so that the compiler can tell me which
> ones
> > are actually used by this component. Unfortunately, it appears that gn will
> tell
> > me all the libs that I depend on, but It won't let me exclude ones that I
> depend
> > on directly.
> > 
> > Is there a systematic way to determine which Mac-related libs my source
> depends
> > on directly?
> 
> Also, clarification: There are a bunch of frameworks pulled in by the gyp
build
> [1]. However, I'm not convinced that they're all needed; the list was copied
> over from content_common.
> 
> Should be, for now, updating the list in gn to match (even though they may not
> all be needed?

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/media_gpu.gy...

[sandersd (OOO until July 31), 2016-05-03 20:54:52]

> Is there a systematic way to determine which Mac-related libs my source
> depends on directly?

Not that I know of. The method I last used was to just look at the actual
symbols in the code, but at this point the code is large enough, and I know so
little about VT VEA, that that would not be trivial.

> Also, clarification: There are a bunch of frameworks pulled in by the gyp
> build. However, I'm not convinced that they're all needed; the list was copied
> over from content_common.

Except for libsandbox and QuartzCore (which I know little about), the rest are
clearly used by VT VDA. That said, vt_glue is still setting up some CoreMedia
symbols, possibly because of API target version requirements.

> Should be, for now, updating the list in gn to match (even though they may not
> all be needed?

I think that's the easiest approach right now.

[Mark Dittmer, 2016-05-04 13:52:14]

Mac fwks: media/gpu/BUILD.gn to match media/gpu/build.gyp

[Mark Dittmer, 2016-05-04 13:53:14]

On 2016/05/03 20:54:52, sandersd wrote:
> > Should be, for now, updating the list in gn to match (even though they may
not
> > all be needed?
> 
> I think that's the easiest approach right now.

Done. PTAL.

[sandersd (OOO until July 31), 2016-05-04 17:48:28]

lgtm

[sandersd (OOO until July 31), 2016-05-04 17:49:00]

On 2016/05/04 17:48:28, sandersd wrote:
> lgtm

% update CL description.

[Mark Dittmer, 2016-05-04 17:59:20]

Description was changed from

==========
Drop unnecessary Mac frameworks from media/gpu

BUG=608816
==========

to

==========
Sync media/gpu gyp and gn Mac framework deps (copy gyp => gn)

BUG=608816
==========

[Mark Dittmer, 2016-05-04 17:59:53]

The CQ bit was checked by markdittmer@chromium.org

[commit-bot: I haz the power, 2016-05-04 18:00:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938113002/40001

[commit-bot: I haz the power, 2016-05-04 19:19:37]

Description was changed from

==========
Sync media/gpu gyp and gn Mac framework deps (copy gyp => gn)

BUG=608816
==========

to

==========
Sync media/gpu gyp and gn Mac framework deps (copy gyp => gn)

BUG=608816
==========

[commit-bot: I haz the power, 2016-05-04 19:19:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-04 19:21:47]

Description was changed from

==========
Sync media/gpu gyp and gn Mac framework deps (copy gyp => gn)

BUG=608816
==========

to

==========
Sync media/gpu gyp and gn Mac framework deps (copy gyp => gn)

BUG=608816

Committed: https://crrev.com/406527c97434a63dea38c3b77024f8dde2765c34
Cr-Commit-Position: refs/heads/master@{#391598}
==========

[commit-bot: I haz the power, 2016-05-04 19:21:48]

Patchset 3 (id:??) landed as
https://crrev.com/406527c97434a63dea38c3b77024f8dde2765c34
Cr-Commit-Position: refs/heads/master@{#391598}