Issue 19381007: Remove unused includes of plugin_list.h. Also remove unused ContentClient and webkit_support method…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19381007: Remove unused includes of plugin_list.h. Also remove unused ContentClient and webkit_support method… (Closed)

Created:
7 years, 5 months ago by jam

Modified:
7 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove unused includes of plugin_list.h. Also remove unused ContentClient and webkit_support methods that referenced or used PluginList. BUG=237249 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211830

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -148 lines)			Patch
M	chrome/browser/plugins/chrome_plugin_service_filter.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/plugins/plugin_finder_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_content_client.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_content_client.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/common/chrome_content_client_ios.mm	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/plugins/plugin_placeholder.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/plugin_service_impl.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	content/plugin/plugin_thread.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/public/common/content_client.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_host.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/plugins/npapi/webplugin_delegate_impl_win.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/support/platform_support_mac.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	webkit/support/test_webplugin_page_delegate.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	webkit/support/test_webplugin_page_delegate.cc	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	webkit/support/webkit_support.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	3 chunks	+0 lines, -35 lines	0 comments	Download
M	webkit/support/webkit_support.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jamesr

7 years, 5 months ago (2013-07-16 19:57:17 UTC) #2

lgtm

looks like WebPluginContainerTest bypasses this by hooking
WebFrameClient::createPlugin()

Expand Messages | Collapse Messages