Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: sync/internal_api/public/base/invalidation.h

Issue 19381005: Add version field to syncer::Invalidation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/test/integration/sync_test.cc ('k') | sync/internal_api/public/base/invalidation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/base/invalidation.h
diff --git a/sync/internal_api/public/base/invalidation.h b/sync/internal_api/public/base/invalidation.h
index e1e274ed13be1edcc7d5778e71d53441eff0f823..851dbed747338433be6db6ba745318c87040b3bc 100644
--- a/sync/internal_api/public/base/invalidation.h
+++ b/sync/internal_api/public/base/invalidation.h
@@ -43,11 +43,14 @@ class SYNC_EXPORT AckHandle {
};
// Represents a local invalidation, and is roughly analogous to
-// invalidation::Invalidation. It contains a payload (which may be empty) and an
+// invalidation::Invalidation. It contains a version (which may be
+// kUnknownVersion), a payload (which may be empty) and an
// associated ack handle that an InvalidationHandler implementation can use to
// acknowledge receipt of the invalidation. It does not embed the object ID,
// since it is typically associated with it through ObjectIdInvalidationMap.
struct SYNC_EXPORT Invalidation {
+ static const int64 kUnknownVersion;
+
Invalidation();
~Invalidation();
@@ -56,6 +59,7 @@ struct SYNC_EXPORT Invalidation {
scoped_ptr<base::DictionaryValue> ToValue() const;
bool ResetFromValue(const base::DictionaryValue& value);
+ int64 version;
std::string payload;
AckHandle ack_handle;
};
« no previous file with comments | « chrome/browser/sync/test/integration/sync_test.cc ('k') | sync/internal_api/public/base/invalidation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698