Add version field to syncer::Invalidation.

chrome/browser/sync/test/integration/sync_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/sync_test.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 653 matching lines @@
   notifications_enabled_ = true;
 }
 
 void SyncTest::TriggerNotification(syncer::ModelTypeSet changed_types) {
   ASSERT_TRUE(ServerSupportsNotificationControl());
   const std::string& data =
       syncer::P2PNotificationData(
           "from_server",
           syncer::NOTIFY_ALL,
           syncer::ObjectIdSetToInvalidationMap(
-              syncer::ModelTypeSetToObjectIdSet(changed_types), std::string())
+              syncer::ModelTypeSetToObjectIdSet(changed_types),
+              syncer::Invalidation::UNKNOWN_VERSION,

[rlarocque, 2013/07/16 18:33:16]

kUnknownVersion?

[Steve Condie, 2013/07/16 21:23:06]

Thanks. Missed this because I didn't build the sync integration tests. I have
now built and run sync_unit_tests, sync_integration_tests, and
sync_endtoend_tests. Is there anything else?

[rlarocque, 2013/07/16 21:33:37]

The existence of sync_endtoend_tests is news to me.

You might also want to try sync_client and sync_listen_notifications.  I don't
think there are any tests that require them to run, but they will break the
trybots if they don't compile

[Steve Condie, 2013/07/16 21:49:47]

Done.

+              std::string())
           ).ToString();
   const std::string& path =
       std::string("chromiumsync/sendnotification?channel=") +
       syncer::kSyncP2PNotificationChannel + "&data=" + data;
   ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
   ASSERT_EQ("Notification sent",
             UTF16ToASCII(browser()->tab_strip_model()->GetActiveWebContents()->
                 GetTitle()));
 }
 
@@ skipping 140 matching lines @@
 
 void SyncTest::SetProxyConfig(net::URLRequestContextGetter* context_getter,
                               const net::ProxyConfig& proxy_config) {
   base::WaitableEvent done(false, false);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&SetProxyConfigCallback, &done,
                  make_scoped_refptr(context_getter), proxy_config));
   done.Wait();
 }