Remove SkBitmapHeap and SkBitmapHeapReader. They're unused.

Remove SkBitmapHeap and SkBitmapHeapReader. They're unused.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1938033002

Committed: https://skia.googlesource.com/skia/+/444f1ba1b7fcca7eca9fda839ca6b613ff31135e

[Brian Osman, 2016-05-02 16:53:00]

Description was changed from

==========
Remove SkBitmapHeap and SkBitmapHeapReader. They're unused.

BUG=skia:
==========

to

==========
Remove SkBitmapHeap and SkBitmapHeapReader. They're unused.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-05-02 16:54:49]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 16:54:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938033002/1

[Brian Osman, 2016-05-02 16:55:13]

brianosman@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[reed1, 2016-05-02 17:02:33]

lgtm

[commit-bot: I haz the power, 2016-05-02 17:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 17:05:41]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-05-02 17:06:22]

https://codereview.chromium.org/1938033002/diff/1/src/core/SkReadBuffer.cpp
File src/core/SkReadBuffer.cpp (right):

https://codereview.chromium.org/1938033002/diff/1/src/core/SkReadBuffer.cpp#n...
src/core/SkReadBuffer.cpp:189: SkErrorInternals::SetError(kParseError_SkError,
"SkWriteBuffer::writeBitmap "
I couldn't figure out how recently setBitmapHeap was killed - it seems to be a
long time ago. Should this code still read the two integers to make sure we're
advancing the buffer to the correct spot before failing out?

[mtklein, 2016-05-02 18:14:14]

https://codereview.chromium.org/1938033002/diff/1/src/core/SkReadBuffer.cpp
File src/core/SkReadBuffer.cpp (right):

https://codereview.chromium.org/1938033002/diff/1/src/core/SkReadBuffer.cpp#n...
src/core/SkReadBuffer.cpp:189: SkErrorInternals::SetError(kParseError_SkError,
"SkWriteBuffer::writeBitmap "
On 2016/05/02 at 17:06:22, Brian Osman wrote:
> I couldn't figure out how recently setBitmapHeap was killed - it seems to be a
long time ago. Should this code still read the two integers to make sure we're
advancing the buffer to the correct spot before failing out?

It looks like we were at picture version 39 when we switched away from
SkBitmapHeap.
This probably means we should bump SkPicture::MIN_PICTURE_VERSION to 40.

Alternatively, we can keep reading the two ints for now to at least be able to
keep parsing those (~17-month) old .skps... we just wouldn't see any bitmaps.

[Brian Osman, 2016-05-02 21:25:30]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 21:25:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938033002/20001

[Brian Osman, 2016-05-02 21:26:01]

Put back the two int reads so we don't completely break on v39.

[commit-bot: I haz the power, 2016-05-02 21:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 21:36:03]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-05-02 21:51:22]

lgtm

[Brian Osman, 2016-05-03 13:06:38]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-05-03 13:06:39]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1938033002/#ps20001
(title: "Restore ability to partially read old SKPs")

[commit-bot: I haz the power, 2016-05-03 13:06:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938033002/20001

[commit-bot: I haz the power, 2016-05-03 13:07:40]

Description was changed from

==========
Remove SkBitmapHeap and SkBitmapHeapReader. They're unused.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove SkBitmapHeap and SkBitmapHeapReader. They're unused.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/444f1ba1b7fcca7eca9fda839ca6b613ff31135e
==========

[commit-bot: I haz the power, 2016-05-03 13:07:41]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/444f1ba1b7fcca7eca9fda839ca6b613ff31135e