Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1937963003: [Media Router WebUI] Move listeners to afterNextRender(). (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Move listeners to afterNextRender(). Moving all listener setup to after initial render, rather than using the Polymer listeners block, will allow the WebUI to render faster. BUG=549289 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f086d731245c5a5c300a98fbfb3e410fbf3e6220 Cr-Commit-Position: refs/heads/master@{#391653}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -136 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js View 4 chunks +124 lines, -106 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_route_tests.js View 1 chunk +24 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
apacible
PTAL, thanks!
4 years, 7 months ago (2016-05-04 16:21:26 UTC) #7
imcheng
lgtm
4 years, 7 months ago (2016-05-04 20:14:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937963003/20001
4 years, 7 months ago (2016-05-04 20:37:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-04 22:08:56 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 22:10:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f086d731245c5a5c300a98fbfb3e410fbf3e6220
Cr-Commit-Position: refs/heads/master@{#391653}

Powered by Google App Engine
This is Rietveld 408576698