[turbofan] Nuke types before entering the concurrent phase.

[turbofan] Nuke types before entering the concurrent phase.

It is unsound to look at the types in the TurboFan graphs after the
representation selection (and early optimization) phases, because

 (a) the remaining phases (might) run concurrently, and
 (b) the types may not be accurate (or even correct) after
     representation selection due to the way we deal with
     truncations.

So in Debug builds we now explicitly remove all types from the nodes
right after we uninstall the Typer decorator from the Graph, so any
further attempt to access the Type of a Node will lead to a crash (again
in Debug only for now).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
BUG=v8:4969
LOG=n

Committed: https://crrev.com/914ad0a3799550f9d5a2a8735274b3518b351bba
Cr-Commit-Position: refs/heads/master@{#35920}

[Benedikt Meurer, 2016-05-02 04:34:17]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 04:34:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1937803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1937803002/1

[commit-bot: I haz the power, 2016-05-02 04:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 04:51:35]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-05-02 05:12:42]

bmeurer@chromium.org changed reviewers:
+ yangguo@chromium.org

[Benedikt Meurer, 2016-05-02 05:12:43]

Hey Yang,

Please take a look.

Thanks,
Benedikt

[Yang, 2016-05-02 05:16:38]

lgtm

[Benedikt Meurer, 2016-05-02 05:22:11]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-05-02 05:22:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1937803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1937803002/1

[commit-bot: I haz the power, 2016-05-02 05:24:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-02 05:25:20]

Description was changed from

==========
[turbofan] Nuke types before entering the concurrent phase.

It is unsound to look at the types in the TurboFan graphs after the
representation selection (and early optimization) phases, because

 (a) the remaining phases (might) run concurrently, and
 (b) the types may not be accurate (or even correct) after
     representation selection due to the way we deal with
     truncations.

So in Debug builds we now explicitly remove all types from the nodes
right after we uninstall the Typer decorator from the Graph, so any
further attempt to access the Type of a Node will lead to a crash (again
in Debug only for now).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
BUG=v8:4969
LOG=n
==========

to

==========
[turbofan] Nuke types before entering the concurrent phase.

It is unsound to look at the types in the TurboFan graphs after the
representation selection (and early optimization) phases, because

 (a) the remaining phases (might) run concurrently, and
 (b) the types may not be accurate (or even correct) after
     representation selection due to the way we deal with
     truncations.

So in Debug builds we now explicitly remove all types from the nodes
right after we uninstall the Typer decorator from the Graph, so any
further attempt to access the Type of a Node will lead to a crash (again
in Debug only for now).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
BUG=v8:4969
LOG=n

Committed: https://crrev.com/914ad0a3799550f9d5a2a8735274b3518b351bba
Cr-Commit-Position: refs/heads/master@{#35920}
==========

[commit-bot: I haz the power, 2016-05-02 05:25:21]

Patchset 1 (id:??) landed as
https://crrev.com/914ad0a3799550f9d5a2a8735274b3518b351bba
Cr-Commit-Position: refs/heads/master@{#35920}