Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1937783002: Provide shipping in PaymentRequest response (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, haraken, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide shipping in PaymentRequest result If the merchant provides non-NULL shipping options, the merchant does not need shipping address to calculate shipping costs. The UI selects the default shipping address, but does not send it to the merchant. This patch sends the shipping address to the merchant when the user clicks "Pay". BUG=608222 Committed: https://crrev.com/f63c3bce0928c9534671fb325d45fd1524ac6b37 Cr-Commit-Position: refs/heads/master@{#391133}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Anon namespace #

Total comments: 4

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 2 chunks +16 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 2 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidators.h View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp View 1 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/payments/payment_request.mojom View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
please use gerrit instead
dfalcantara@, ptal PaymentRequestImpl.java mek@, ptal third_party/WebKit/Source/modules/payments/*. palmer@, ptal payment_request.mojom
4 years, 7 months ago (2016-05-01 22:39:09 UTC) #2
please use gerrit instead
mek@, ptal third_party/WebKit/Source/modules/payments/*.
4 years, 7 months ago (2016-05-01 22:39:53 UTC) #5
gone
android bits lgtm
4 years, 7 months ago (2016-05-02 17:45:37 UTC) #6
Marijn Kruisselbrink
other than some of the helper code in your unit test really needing to be ...
4 years, 7 months ago (2016-05-02 19:02:27 UTC) #7
please use gerrit instead
https://codereview.chromium.org/1937783002/diff/1/third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp File third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp (right): https://codereview.chromium.org/1937783002/diff/1/third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp#newcode13 third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp:13: struct TestCase { On 2016/05/02 19:02:27, Marijn Kruisselbrink wrote: ...
4 years, 7 months ago (2016-05-02 20:34:45 UTC) #8
palmer
https://codereview.chromium.org/1937783002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java (right): https://codereview.chromium.org/1937783002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java#newcode506 chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:506: Nit: Don't need a blank line here. https://codereview.chromium.org/1937783002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java#newcode512 chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:512: ...
4 years, 7 months ago (2016-05-02 21:58:41 UTC) #9
please use gerrit instead
palmer@, ptal patch 3. https://codereview.chromium.org/1937783002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java (right): https://codereview.chromium.org/1937783002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java#newcode506 chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:506: On 2016/05/02 21:58:41, palmer wrote: ...
4 years, 7 months ago (2016-05-02 22:08:19 UTC) #10
palmer
Great, thanks. LGTM.
4 years, 7 months ago (2016-05-02 22:09:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937783002/40001
4 years, 7 months ago (2016-05-02 22:12:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-03 01:03:01 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 01:04:01 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f63c3bce0928c9534671fb325d45fd1524ac6b37
Cr-Commit-Position: refs/heads/master@{#391133}

Powered by Google App Engine
This is Rietveld 408576698