Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 7 months ago by Mostyn Bramley-Moore Modified:
4 years, 7 months ago Reviewers:
Timothy Loh CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionremove obsolete todo note for CSS property to histogram id mapping
It was decided not to move these (necessarily) hardcoded ids.
BUG=234940
NOTRY=true
Committed: https://crrev.com/2704fdcf0e1fa55b987962648b524b9a72e713ef
Cr-Commit-Position: refs/heads/master@{#390917}
Patch Set 1 #
Created: 4 years, 7 months ago
Messages
Total messages: 14 (7 generated)
mostynb@opera.com changed reviewers: + timloh@chromium.org
@Tim: can you please give this a thumbs-up?
lgtm
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937773002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== remove obsolete todo note for CSS property to histogram id mapping It was decided not to move these (necessarily) hardcoded ids. BUG=234940 ========== to ========== remove obsolete todo note for CSS property to histogram id mapping It was decided not to move these (necessarily) hardcoded ids. BUG=234940 NOTRY=true ==========
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937773002/1
Message was sent while issue was closed.
Description was changed from ========== remove obsolete todo note for CSS property to histogram id mapping It was decided not to move these (necessarily) hardcoded ids. BUG=234940 NOTRY=true ========== to ========== remove obsolete todo note for CSS property to histogram id mapping It was decided not to move these (necessarily) hardcoded ids. BUG=234940 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== remove obsolete todo note for CSS property to histogram id mapping It was decided not to move these (necessarily) hardcoded ids. BUG=234940 NOTRY=true ========== to ========== remove obsolete todo note for CSS property to histogram id mapping It was decided not to move these (necessarily) hardcoded ids. BUG=234940 NOTRY=true Committed: https://crrev.com/2704fdcf0e1fa55b987962648b524b9a72e713ef Cr-Commit-Position: refs/heads/master@{#390917} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2704fdcf0e1fa55b987962648b524b9a72e713ef Cr-Commit-Position: refs/heads/master@{#390917} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
