Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1937773002: remove obsolete todo note for CSS property to histogram id mapping (Closed)

Created:
4 years, 7 months ago by Mostyn Bramley-Moore
Modified:
4 years, 7 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove obsolete todo note for CSS property to histogram id mapping It was decided not to move these (necessarily) hardcoded ids. BUG=234940 NOTRY=true Committed: https://crrev.com/2704fdcf0e1fa55b987962648b524b9a72e713ef Cr-Commit-Position: refs/heads/master@{#390917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Mostyn Bramley-Moore
@Tim: can you please give this a thumbs-up?
4 years, 7 months ago (2016-05-01 21:21:37 UTC) #2
Timothy Loh
lgtm
4 years, 7 months ago (2016-05-02 00:39:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937773002/1
4 years, 7 months ago (2016-05-02 07:19:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/214652)
4 years, 7 months ago (2016-05-02 11:14:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937773002/1
4 years, 7 months ago (2016-05-02 11:16:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 11:19:35 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 11:20:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2704fdcf0e1fa55b987962648b524b9a72e713ef
Cr-Commit-Position: refs/heads/master@{#390917}

Powered by Google App Engine
This is Rietveld 408576698