Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1937693002: Replace scoped_ptr with unique_ptr everywhere (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, interface-changes_webrtc.org, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, pbos-webrtc, perkj_webrtc, aluebs-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@unique5
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr everywhere But keep #including scoped_ptr.h in .h files, so as not to break WebRTC users who expect those .h files to give them rtc::scoped_ptr. BUG=webrtc:5520 Committed: https://crrev.com/bfefb03ec124105f49a19952fa73cf1861b0f262 Cr-Commit-Position: refs/heads/master@{#12581}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -158 lines) Patch
M talk/app/webrtc/objc/RTCVideoCapturer.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/quicdatachannel_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M webrtc/api/quicdatatransport_unittest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M webrtc/audio_send_stream.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/base/optional.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/base/scoped_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/thread_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common_audio/audio_ring_buffer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common_audio/real_fourier.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/common_audio/real_fourier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/vad/vad.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/examples/peerconnection/client/conductor.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/linux/main_wnd.h View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/examples/peerconnection/client/main_wnd.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/examples/peerconnection/client/peer_connection_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/examples/relayserver/relayserver_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/base/videoadapter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/base/videobroadcaster.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/media/base/videocapturer_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvoe.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/delay_peak_detector.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/quic/quictransport.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/p2p/quic/quictransport_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M webrtc/pc/yuvscaler_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCDataChannel.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCFileLogger.mm View 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCIceCandidate.mm View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCIceCandidate+Private.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints+Private.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCOpenGLVideoRenderer.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm View 5 chunks +7 lines, -5 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoFrame.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/RTCIceCandidateTest.mm View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/RTCMediaConstraintsTest.mm View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/system_wrappers/include/aligned_malloc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/include/clock.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/system_wrappers/include/data_log_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/utf_util_win.h View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/source/aligned_malloc_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/source/condition_variable_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/source/file_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/system_wrappers/source/logging_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/source/trace_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/test/call_test.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/test/configurable_frame_size_encoder.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/test/fake_audio_device.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/test/fake_network_pipe.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/test/fake_network_pipe_unittest.cc View 10 chunks +11 lines, -10 lines 0 comments Download
M webrtc/test/frame_generator.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/test/frame_generator_unittest.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M webrtc/test/fuzzers/producer_fec_fuzzer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/layer_filtering_transport.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/test/rtp_file_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/rtp_file_reader_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/test/rtp_file_writer_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/test/rtp_rtcp_observer.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/test/test_suite.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/test/testsupport/fileutils.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/tools/agc/activity_metric.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/tools/agc/agc_harness.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/tools/e2e_quality/audio/audio_e2e_harness.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/tools/force_mic_volume_max/force_mic_volume_max.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/tools/frame_editing/frame_editing_lib.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/tools/frame_editing/frame_editing_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/video_capture_input.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_send_stream.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kwiberg-webrtc
This is the last one! (Unless someone manages to sneak in new scoped_ptr uses in ...
4 years, 7 months ago (2016-05-01 12:22:51 UTC) #3
tommi
w00t! lgtm!
4 years, 7 months ago (2016-05-01 16:19:28 UTC) #4
kwiberg-webrtc
On 2016/05/01 16:19:28, tommi-webrtc wrote: > w00t! lgtm! Yes, I had a feeling you wouldn't ...
4 years, 7 months ago (2016-05-01 17:25:26 UTC) #6
tommi
On 2016/05/01 17:25:26, kwiberg-webrtc wrote: > On 2016/05/01 16:19:28, tommi-webrtc wrote: > > w00t! lgtm! ...
4 years, 7 months ago (2016-05-01 19:04:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937693002/20001
4 years, 7 months ago (2016-05-01 21:49:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-01 21:53:51 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfefb03ec124105f49a19952fa73cf1861b0f262
Cr-Commit-Position: refs/heads/master@{#12581}

Powered by Google App Engine
This is Rietveld 408576698