Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4685)

Unified Diff: chrome/browser/component_updater/widevine_cdm_component_installer.cc

Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ready for review. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/widevine_cdm_component_installer.cc
diff --git a/chrome/browser/component_updater/widevine_cdm_component_installer.cc b/chrome/browser/component_updater/widevine_cdm_component_installer.cc
index 2aa8011889ff85e950f5c46931e81a62f006e924..88d8c64a122e946fb8ff944aa2e0de70e7d4f8f0 100644
--- a/chrome/browser/component_updater/widevine_cdm_component_installer.cc
+++ b/chrome/browser/component_updater/widevine_cdm_component_installer.cc
@@ -252,7 +252,7 @@ class WidevineCdmComponentInstallerTraits : public ComponentInstallerTraits {
void ComponentReady(const base::Version& version,
const base::FilePath& path,
std::unique_ptr<base::DictionaryValue> manifest) override;
- base::FilePath GetBaseDirectory() const override;
+ std::string GetASCIIDirectoryName() const override;
void GetHash(std::vector<uint8_t>* hash) const override;
std::string GetName() const override;
std::string GetAp() const override;
@@ -315,10 +315,8 @@ bool WidevineCdmComponentInstallerTraits::VerifyInstallation(
// The base directory on Windows looks like:
// <profile>\AppData\Local\Google\Chrome\User Data\WidevineCdm\.
-base::FilePath WidevineCdmComponentInstallerTraits::GetBaseDirectory() const {
- base::FilePath result;
- PathService::Get(chrome::DIR_COMPONENT_WIDEVINE_CDM, &result);
- return result;
+std::string WidevineCdmComponentInstallerTraits::GetASCIIDirectoryName() const {
+ return "WidevineCdm";
}
void WidevineCdmComponentInstallerTraits::GetHash(

Powered by Google App Engine
This is Rietveld 408576698