chrome/browser/component_updater/sth_set_component_installer.cc - Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/sth_set_component_installer.cc

Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ready for review. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/chrome_main_delegate.cc ('K') | « chrome/browser/component_updater/sth_set_component_installer.h ('k') | chrome/browser/component_updater/supervised_user_whitelist_installer.cc » ('j') | components/component_updater/default_component_installer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/sth_set_component_installer.cc

diff --git a/chrome/browser/component_updater/sth_set_component_installer.cc b/chrome/browser/component_updater/sth_set_component_installer.cc

index fc393ceff3dc209cd2a4dc4d113a438ace725b97..a1aed8197a1707710550fa9317fb1ddd7c97297d 100644

--- a/chrome/browser/component_updater/sth_set_component_installer.cc

+++ b/chrome/browser/component_updater/sth_set_component_installer.cc

@@ -89,10 +89,8 @@ bool STHSetComponentInstallerTraits::VerifyInstallation(

return base::PathExists(GetInstalledPath(install_dir));

}

-base::FilePath STHSetComponentInstallerTraits::GetBaseDirectory() const {

- base::FilePath result;

- PathService::Get(DIR_CERT_TRANS_TREE_STATES, &result);

- return result;

+std::string STHSetComponentInstallerTraits::GetASCIIDirectoryName() const {

+ return "CertificateTransparency";

}

void STHSetComponentInstallerTraits::GetHash(std::vector<uint8_t>* hash) const {