chrome/browser/component_updater/cld_component_installer_unittest.cc - Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/cld_component_installer_unittest.cc

Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ready for review. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/chrome_main_delegate.cc ('K') | « chrome/browser/component_updater/cld_component_installer.cc ('k') | chrome/browser/component_updater/ev_whitelist_component_installer.h » ('j') | components/component_updater/default_component_installer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/cld_component_installer_unittest.cc

diff --git a/chrome/browser/component_updater/cld_component_installer_unittest.cc b/chrome/browser/component_updater/cld_component_installer_unittest.cc

index 5cf6e4834b092fbd30177f28d7c23789fe00f43e..ab9f67c492a7ee9d51ebc252b557adc494d1bc0a 100644

--- a/chrome/browser/component_updater/cld_component_installer_unittest.cc

+++ b/chrome/browser/component_updater/cld_component_installer_unittest.cc

@@ -110,9 +110,8 @@ TEST_F(CldComponentInstallerTest, GetInstalledPath) {

base::CompareCase::SENSITIVE));

}

-TEST_F(CldComponentInstallerTest, GetBaseDirectory) {

- const base::FilePath result = traits_.GetBaseDirectory();

- ASSERT_FALSE(result.empty());

+TEST_F(CldComponentInstallerTest, GetASCIIDirectoryName) {

+ ASSERT_FALSE(traits_.GetASCIIDirectoryName().empty());

}

TEST_F(CldComponentInstallerTest, GetHash) {