chrome/browser/component_updater/cld_component_installer.h - Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/cld_component_installer.h

Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ready for review. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« chrome/app/chrome_main_delegate.cc ('K') | « chrome/browser/component_updater/caps_installer_win.cc ('k') | chrome/browser/component_updater/cld_component_installer.cc » ('j') | components/component_updater/default_component_installer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/cld_component_installer.h

diff --git a/chrome/browser/component_updater/cld_component_installer.h b/chrome/browser/component_updater/cld_component_installer.h

index 32a04fc93c3da32cf1aab6aaebbc10d9ab0b047f..609f6fb7c2d592c4ef94dd6a843a33d14b540cdb 100644

--- a/chrome/browser/component_updater/cld_component_installer.h

+++ b/chrome/browser/component_updater/cld_component_installer.h

@@ -32,7 +32,7 @@ class CldComponentInstallerTraits : public ComponentInstallerTraits {

friend class CldComponentInstallerTest; // For access within SetUp()

friend class test::ComponentCldDataHarness; // For browser tests only

FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, ComponentReady);

- FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, GetBaseDirectory);

+ FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, GetASCIIDirectoryName);

FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, GetHash);

FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, GetInstalledPath);

FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, GetName);

@@ -50,7 +50,7 @@ class CldComponentInstallerTraits : public ComponentInstallerTraits {

void ComponentReady(const base::Version& version,

const base::FilePath& path,

std::unique_ptr<base::DictionaryValue> manifest) override;

- base::FilePath GetBaseDirectory() const override;

+ std::string GetASCIIDirectoryName() const override;

void GetHash(std::vector<uint8_t>* hash) const override;

std::string GetName() const override;

std::string GetAp() const override;