chrome/app/chrome_main_delegate.cc - Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix uninstall bug. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_main_delegate.cc

diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc

index 8ea00c77069be45358207274c58e24df948f0198..eb84e4f56916e86e26fe8b47eb7e40fc0414ae35 100644

--- a/chrome/app/chrome_main_delegate.cc

+++ b/chrome/app/chrome_main_delegate.cc

@@ -724,7 +724,8 @@ void ChromeMainDelegate::PreSandboxStartup() {

// Register component_updater PathProvider after DIR_USER_DATA overidden by

// command line flags. Maybe move the chrome PathProvider down here also?

- component_updater::RegisterPathProvider(chrome::DIR_USER_DATA);

+ component_updater::RegisterPathProvider(chrome::DIR_INTERNAL_PLUGINS,

xhwang 2016/05/03 22:49:42 From the offline discussion it seems we should put

waffles 2016/05/10 18:15:53 Switched to DIR_MODULE. On most platforms, this is

xhwang 2016/05/10 18:58:20 On Mac we don't need to be in "Internet Plug-ins",

waffles 2016/05/11 21:42:57 Added a DIR_COMPONENTS, which is DIR_MODULE usuall

+ chrome::DIR_USER_DATA);

// Enable Message Loop related state asap.

if (command_line.HasSwitch(switches::kMessageLoopHistogrammer))

« no previous file with comments | « no previous file | chrome/browser/component_updater/caps_installer_win.cc » ('j') | components/component_updater/default_component_installer.h » ('J')