Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1937643002: Disable Physical Web onboarding tests (Closed)

Created:
4 years, 7 months ago by mattreynolds
Modified:
4 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews, mmocny
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Physical Web onboarding tests These tests succeed locally but fail on the autobuilders. Temporarily disable them until we can determine why setting the onboarding state fails in this case. BUG=604502 Committed: https://crrev.com/9bc94e62a536efc435ea90a4c825e8a227b030b5 Cr-Commit-Position: refs/heads/master@{#391369}

Patch Set 1 #

Total comments: 2

Patch Set 2 : reference bug in disabled tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mattreynolds
Hi Tommy, PTAL These tests were failing on the builders and blocking the Discoverer flag ...
4 years, 7 months ago (2016-04-29 23:09:18 UTC) #2
mattreynolds
Friendly ping (these tests are blocking the Discoverer flag changes)
4 years, 7 months ago (2016-05-03 18:36:48 UTC) #3
nyquist
lgtm, but add a comment above both tests referring to the bug before you submit ...
4 years, 7 months ago (2016-05-03 20:06:58 UTC) #4
mattreynolds
Thanks! https://codereview.chromium.org/1937643002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java (right): https://codereview.chromium.org/1937643002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java#newcode108 chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java:108: @DisabledTest On 2016/05/03 20:06:58, nyquist wrote: > Please ...
4 years, 7 months ago (2016-05-03 21:18:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937643002/20001
4 years, 7 months ago (2016-05-03 21:19:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 21:59:45 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 22:01:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bc94e62a536efc435ea90a4c825e8a227b030b5
Cr-Commit-Position: refs/heads/master@{#391369}

Powered by Google App Engine
This is Rietveld 408576698