Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 193763002: Listen to WM_TIMECHANGE messages in RenderViewHostImpl on windows (Closed)

Created:
6 years, 9 months ago by jamesr
Modified:
6 years ago
Reviewers:
Mark Mentovai, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, Mark Mentovai
Visibility:
Public.

Description

Listen to WM_TIMECHANGE messages in RenderViewHostImpl on windows This message is broadcasted to all top-level HWNDs when the system time changes, including when the time zone is changed (even if this doesn't actually change the time, for instance when changing between two time zones with the same offset from UTC but different daylight savings time rules). This propagates the notification to render processes so they can update their time zone caches. BUG=288697

Patch Set 1 #

Patch Set 2 : hang monitor off of content::BrowserMainLoop #

Patch Set 3 : process host loop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M content/browser/browser_main_loop.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A content/browser/time_zone_monitor_win.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
A content/browser/time_zone_monitor_win.cc View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
John - could you advise on the best place to put this? I'd like this ...
6 years, 9 months ago (2014-03-11 01:04:14 UTC) #1
jam
On 2014/03/11 01:04:14, jamesr wrote: > John - could you advise on the best place ...
6 years, 9 months ago (2014-03-11 15:56:55 UTC) #2
Mark Mentovai
This is where it’s going to get hairy. We don’t really need one system-level observer ...
6 years, 9 months ago (2014-03-11 16:07:51 UTC) #3
jam
On 2014/03/11 16:07:51, Mark Mentovai wrote: > This is where it’s going to get hairy. ...
6 years, 9 months ago (2014-03-11 16:43:28 UTC) #4
Mark Mentovai
That works for me.
6 years, 9 months ago (2014-03-11 16:54:04 UTC) #5
jamesr
PTAL - this hangs a TimeZoneMonitorWin off of the BrowserMainLoop that on notification iterates through ...
6 years, 9 months ago (2014-03-11 21:48:59 UTC) #6
Mark Mentovai
Yeah, I can make the Mac implementation live in the same place as this, and ...
6 years, 9 months ago (2014-03-11 21:59:08 UTC) #7
jamesr
Patch set #3 does a loop over process hosts since that's where NotifyTimezoneChanged() lives as ...
6 years, 9 months ago (2014-03-14 23:06:15 UTC) #8
jam
6 years, 9 months ago (2014-03-17 17:08:29 UTC) #9
On 2014/03/14 23:06:15, jamesr wrote:
> Patch set #3 does a loop over process hosts since that's where
> NotifyTimezoneChanged() lives as of
> http://src.chromium.org/viewvc/chrome?view=revision&revision=256876

aren't we going to make this cross platform? if so it seems that browsermainloop
should have a cross platform type

Powered by Google App Engine
This is Rietveld 408576698