Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1937563002: PaymentRequest shipping address labels. (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
Reviewers:
Mathieu, gone
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentRequest shipping address labels. The PaymentRequest UI should show the shipping address on two lines: LABEL: The address on a single line without the name of the recipient. SUB-LABEL: The name of the recipient. BUG=607971 Committed: https://crrev.com/5eaf0ec1e4640410c82c86734af5f60b3fd0532a Cr-Commit-Position: refs/heads/master@{#390795}

Patch Set 1 : #

Messages

Total messages: 13 (4 generated)
please use gerrit instead
dfalcantara@, ptal chrome/android/. mathp@, ptal chrome/browser/.
4 years, 7 months ago (2016-04-29 19:01:47 UTC) #3
Mathieu
chrome/browser lgtm
4 years, 7 months ago (2016-04-29 19:41:48 UTC) #4
gone
android lgtm
4 years, 7 months ago (2016-04-29 22:06:35 UTC) #5
please use gerrit instead
I've just ticked the CQ on http://crrev.com/1926903003, which might conflict with this patch. I will ...
4 years, 7 months ago (2016-04-29 22:08:28 UTC) #6
please use gerrit instead
No conflict, sending to cq as is.
4 years, 7 months ago (2016-04-29 22:59:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937563002/20001
4 years, 7 months ago (2016-04-29 22:59:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-04-29 23:04:53 UTC) #10
mdjones
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/1929163004/ by mdjones@chromium.org. ...
4 years, 7 months ago (2016-04-29 23:41:24 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:29:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5eaf0ec1e4640410c82c86734af5f60b3fd0532a
Cr-Commit-Position: refs/heads/master@{#390795}

Powered by Google App Engine
This is Rietveld 408576698