Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1937483002: Convert track-kind* tests to testharness.js (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track-kind* tests to testharness.js Cleaning up track-kind* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/cbde023ed9f839415f2191fa2409cdf43ad59394 Cr-Commit-Position: refs/heads/master@{#391582}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -268 lines) Patch
M third_party/WebKit/LayoutTests/media/track/track-kind.html View 1 1 chunk +72 lines, -76 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/track-kind-expected.txt View 1 chunk +0 lines, -99 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-kind-user-preference.html View 1 chunk +45 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/track-kind-user-preference-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Srirama
PTAL
4 years, 7 months ago (2016-04-29 17:12:04 UTC) #3
mlamouri (slow - plz ping)
lgtm with comment applied. https://codereview.chromium.org/1937483002/diff/1/third_party/WebKit/LayoutTests/media/track/track-kind.html File third_party/WebKit/LayoutTests/media/track/track-kind.html (right): https://codereview.chromium.org/1937483002/diff/1/third_party/WebKit/LayoutTests/media/track/track-kind.html#newcode62 third_party/WebKit/LayoutTests/media/track/track-kind.html:62: function setKind(value, cueIsVisible) { Can ...
4 years, 7 months ago (2016-05-04 13:59:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937483002/20001
4 years, 7 months ago (2016-05-04 17:43:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 18:46:31 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:48:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cbde023ed9f839415f2191fa2409cdf43ad59394
Cr-Commit-Position: refs/heads/master@{#391582}

Powered by Google App Engine
This is Rietveld 408576698