Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1937473002: Revert of 🌈 Upstream some code related to PolicyAuditing. (Closed)

Created:
4 years, 7 months ago by mdjones
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🌈 Upstream some code related to PolicyAuditing. (patchset #6 id:100001 of https://codereview.chromium.org/1930963002/ ) Reason for revert: Causes compile failure on clang-clankium-tot-builder. Original issue's description: > Upstream some code related to PolicyAuditing. > > Provides basic mapping from security failure states to an enum for consumption > by auditors. > BUG=607207 > TBR=thestig TBR=bauerb@chromium.org,yfriedman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607207 Committed: https://crrev.com/85e0763ffbf034546e0748581d70347d69a7d0f2 Cr-Commit-Position: refs/heads/master@{#390674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -111 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/policy/PolicyAuditor.java View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/android/policy/policy_auditor.h View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/android/policy/policy_auditor.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mdjones
Created Revert of 🌈 Upstream some code related to PolicyAuditing.
4 years, 7 months ago (2016-04-29 16:55:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937473002/1
4 years, 7 months ago (2016-04-29 16:56:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 16:57:03 UTC) #4
mdjones
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1933813002/ by mdjones@chromium.org. ...
4 years, 7 months ago (2016-04-29 16:59:19 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85e0763ffbf034546e0748581d70347d69a7d0f2
Cr-Commit-Position: refs/heads/master@{#390674}

Powered by Google App Engine
This is Rietveld 408576698