Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1937453002: Replace CFX_PtryArray with typesafe CFX_ArrayTemplate, Part 7 (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace CFX_PtryArray with typesafe CFX_ArrayTemplate, Part 7 Remaining uses are all in fxbarcode/. Committed: https://pdfium.googlesource.com/pdfium/+/d15ba4e29607665db35bc6fb610cc566981b324a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M xfa/fgas/crt/fgas_utils.h View 1 chunk +2 lines, -1 line 1 comment Download
M xfa/fgas/crt/fgas_utils.cpp View 4 chunks +16 lines, -20 lines 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 1 chunk +18 lines, -18 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, part 7. https://codereview.chromium.org/1937453002/diff/1/xfa/fgas/crt/fgas_utils.h File xfa/fgas/crt/fgas_utils.h (right): https://codereview.chromium.org/1937453002/diff/1/xfa/fgas/crt/fgas_utils.h#newcode210 xfa/fgas/crt/fgas_utils.h:210: CFX_ArrayTemplate<void*>* m_pData; Note: this really does ...
4 years, 7 months ago (2016-04-29 16:03:17 UTC) #2
Lei Zhang
lgtm
4 years, 7 months ago (2016-04-29 16:40:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937453002/1
4 years, 7 months ago (2016-04-29 16:45:31 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 16:45:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d15ba4e29607665db35bc6fb610cc566981b...

Powered by Google App Engine
This is Rietveld 408576698