Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1937433002:
HTML <canvas>: add WEBP lossless encoding support (Closed)
|
Created:
4 years, 7 months ago by Noel Gordon Modified:
4 years, 7 months ago CC:
chromium-reviews, blink-reviews, jzern, kinuko+watch, skal, urvang Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionHTML <canvas>: add WEBP lossless encoding support
Deem "image/webp" to be an image format that supports alpha for the
purposes of the HTML <canvas> spec: no need to implement the canvas
composite-over-black spec requirement anymore, so we can remove the
associated code, rgbPictureImport().
The WEBP image importer now includes the alpha channel always. When
the image has no alpha, the libwebp encoder notices and removes the
alpha channel from the encoded image.
For "image/webp" encoding at maximum quality, maintain sharpness to
match the JPEG encoder behavior (use WEBP lossless encoding).
Change in behavior. Add new tests:
fast/canvas/canvas-toDataURL-webp-maximum-quality.html
fast/canvas/canvas-toDataURL-webp-alpha.html
Update existing tests:
fast/canvas/canvas-toBlob-webp-maximum-quality.html
fast/canvas/canvas-toDataURL-webp.html
Add "image/webp" to the <canvas> mime-type tests:
fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html
fast/canvas/toDataURL-supportedTypes.html
Note: regarding "image/gif" and toDataURL-supportedTypes.html. This
format has never been supported by toDataURL. Move it into the list
of unsupported mime types.
BUG=523098
Committed: https://crrev.com/dd15c29bcac43daf9271fbb60bd5a93607e39fe5
Cr-Commit-Position: refs/heads/master@{#391429}
Patch Set 1 #Patch Set 2 : More test expectations. #Patch Set 3 : Tweak tests. #Patch Set 4 : Merge to ToT #
Total comments: 6
Patch Set 5 : Patch for landing. #
Total comments: 1
Messages
Total messages: 39 (19 generated)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937433002/1
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937433002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937433002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== crbug.com/523098 BUG=523098 ========== to ========== Add WEBP lossless encoding support to HTML <canvas> element Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec (no need to implement the canvas composite-over-black spec requirement anymore, remove that code). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded output image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html BUG=523098 ==========
noel@chromium.org changed reviewers: + urvang@chromium.org, xlai@chromium.org
Description was changed from ========== Add WEBP lossless encoding support to HTML <canvas> element Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec (no need to implement the canvas composite-over-black spec requirement anymore, remove that code). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded output image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html BUG=523098 ========== to ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec (no need to implement the canvas composite-over-black spec requirement anymore, remove that code). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded output image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html BUG=523098 ==========
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937433002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec (no need to implement the canvas composite-over-black spec requirement anymore, remove that code). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded output image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html BUG=523098 ========== to ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec (no need to implement the canvas composite-over-black spec requirement anymore, remove that code). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded output image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html BUG=523098 ==========
https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/canvas/toDataURL-supportedTypes.html (left): https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/canvas/toDataURL-supportedTypes.html:28: "image/gif", GIF is not supported? If so, this should ideally be a separate patch. Or at least, this should be mentioned in the patch description. https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp (right): https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp:41: return static_cast<Vector<unsigned char>*>(picture->custom_ptr)->append(data, size), 1; My first impression was "What sorcery is this?" :P Although I understand that "1" is returned here, better to keep it simple; two clear statements as before. https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp:61: if (quality >= 100) Create and use a variable "bool use_lossless_encoding = (quality >= 100)" instead for clarity.
I can only comment on the tests. Tried the patch locally and the webp images generated in the tests lgtm.
Description was changed from ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec (no need to implement the canvas composite-over-black spec requirement anymore, remove that code). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded output image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html BUG=523098 ========== to ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec (no need to implement the canvas composite-over-black spec requirement anymore, remove that code). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded output image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ==========
https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/canvas/toDataURL-supportedTypes.html (left): https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/canvas/toDataURL-supportedTypes.html:28: "image/gif", On 2016/05/03 17:28:19, urvang wrote: > GIF is not supported? Nope. There has never been a toDataURL("image/gif") encoder in Blink, nor in WebKit iirc. > If so, this should ideally be a separate patch. > Or at least, this should be mentioned in the patch description. Done, noted in change description.
https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp (right): https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp:41: return static_cast<Vector<unsigned char>*>(picture->custom_ptr)->append(data, size), 1; On 2016/05/03 17:28:19, urvang wrote: > My first impression was "What sorcery is this?" :P :P done. https://codereview.chromium.org/1937433002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp:61: if (quality >= 100) On 2016/05/03 17:28:19, urvang wrote: > Create and use a variable "bool use_lossless_encoding = (quality >= 100)" > instead for clarity. Done: useLosslessEncoding.
https://codereview.chromium.org/1937433002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp (right): https://codereview.chromium.org/1937433002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp:73: config.quality = 75; Note urvang@: the config.{quality,method} values used here are the ones you suggested from a previous patch. I assume they still look good.
The CQ bit was checked by noel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xlai@chromium.org Link to the patchset: https://codereview.chromium.org/1937433002/#ps80001 (title: "Patch for landing.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937433002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937433002/80001
LGTM On Tue, May 3, 2016, 6:17 PM commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1937433002/80001 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1937433002/80001 > > > https://codereview.chromium.org/1937433002/ > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
LGTM On Tue, May 3, 2016, 6:17 PM commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1937433002/80001 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1937433002/80001 > > > https://codereview.chromium.org/1937433002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Description was changed from ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec (no need to implement the canvas composite-over-black spec requirement anymore, remove that code). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded output image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ========== to ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec. No need to implement the canvas composite-over-black requirement anymore, remove that code. The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ==========
Description was changed from ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec. No need to implement the canvas composite-over-black requirement anymore, remove that code. The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ========== to ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec: no need to implement the canvas composite-over-black requirement anymore, remove that code. The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ==========
Description was changed from ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec: no need to implement the canvas composite-over-black requirement anymore, remove that code. The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ========== to ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec: no need to implement the canvas composite-over-black spec requirement anymore, so we can remove the associated code, rgbPictureImport(). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ==========
On 2016/05/03 19:20:26, xlai (Olivia) wrote: > I can only comment on the tests. Tried the patch locally and the webp images > generated in the tests lgtm. Thanks for testing. Note I used [ NeedsManualRebaseline ] in TestExpectations because the rebaseline server is off-line until further notice
On 2016/05/04 01:24:28, urvang wrote: > LGTM Right, submitting.
Message was sent while issue was closed.
Description was changed from ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec: no need to implement the canvas composite-over-black spec requirement anymore, so we can remove the associated code, rgbPictureImport(). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ========== to ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec: no need to implement the canvas composite-over-black spec requirement anymore, so we can remove the associated code, rgbPictureImport(). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec: no need to implement the canvas composite-over-black spec requirement anymore, so we can remove the associated code, rgbPictureImport(). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 ========== to ========== HTML <canvas>: add WEBP lossless encoding support Deem "image/webp" to be an image format that supports alpha for the purposes of the HTML <canvas> spec: no need to implement the canvas composite-over-black spec requirement anymore, so we can remove the associated code, rgbPictureImport(). The WEBP image importer now includes the alpha channel always. When the image has no alpha, the libwebp encoder notices and removes the alpha channel from the encoded image. For "image/webp" encoding at maximum quality, maintain sharpness to match the JPEG encoder behavior (use WEBP lossless encoding). Change in behavior. Add new tests: fast/canvas/canvas-toDataURL-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp-alpha.html Update existing tests: fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-webp.html Add "image/webp" to the <canvas> mime-type tests: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html Note: regarding "image/gif" and toDataURL-supportedTypes.html. This format has never been supported by toDataURL. Move it into the list of unsupported mime types. BUG=523098 Committed: https://crrev.com/dd15c29bcac43daf9271fbb60bd5a93607e39fe5 Cr-Commit-Position: refs/heads/master@{#391429} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/dd15c29bcac43daf9271fbb60bd5a93607e39fe5 Cr-Commit-Position: refs/heads/master@{#391429} |
