Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2435)

Unified Diff: blimp/tools/generate-target-manifest.py

Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missed output location update in doc. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/tools/generate-target-manifest.py
diff --git a/blimp/tools/generate-engine-manifest.py b/blimp/tools/generate-target-manifest.py
similarity index 79%
rename from blimp/tools/generate-engine-manifest.py
rename to blimp/tools/generate-target-manifest.py
index 5a3771af6409b1910fc26debd191a5615e43b190..77ac5323d5f8bc2dae3157cc1c215700954029aa 100755
--- a/blimp/tools/generate-engine-manifest.py
+++ b/blimp/tools/generate-target-manifest.py
@@ -3,13 +3,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-'''Generates a list of runtime Blimp Engine runtime dependencies.'''
-
+'''Generates a list of Blimp target runtime dependencies.'''
import argparse
import fnmatch
-import os
-
# Returns True if |entry| matches any of the patterns in |blacklist|.
def IsBlacklisted(entry, blacklist):
@@ -28,22 +25,24 @@ def main():
'(required)'),
required=True,
metavar='FILE')
+ parser.add_argument('--blacklist',
+ help=('name and path of the blacklist file to use'),
+ required=True)
args = parser.parse_args()
with open(args.runtime_deps_file) as f:
deps = f.read().splitlines()
header = [
- '# Runtime dependencies for the Blimp Engine',
+ '# Runtime dependencies for: ' + args.runtime_deps_file,
'#',
'# Note: Any unnecessary dependencies should be added to',
- '# manifest-blacklist.txt and this file should be regenerated.',
+ '# the appropriate blacklist and this file should be regenerated.',
'',
]
blacklist_patterns = []
- with open(os.path.join(os.sys.path[0], 'manifest-blacklist.txt'), 'r') \
- as blacklist_file:
+ with open(args.blacklist, 'r') as blacklist_file:
blacklist_patterns = \
[entry.partition('#')[0].strip() for entry \
in blacklist_file.readlines()]

Powered by Google App Engine
This is Rietveld 408576698