Refactor generate engine manifest to accept blacklist as an argument.

blimp/tools/generate-engine-manifest.py

Index: blimp/tools/generate-engine-manifest.py
diff --git a/blimp/tools/generate-engine-manifest.py b/blimp/tools/generate-engine-manifest.py
index 327f6a8c06bb1060c33ecc195d3a96f3c463b28c..7eacfde525817f00568224a4aa3792689a264d93 100755
--- a/blimp/tools/generate-engine-manifest.py
+++ b/blimp/tools/generate-engine-manifest.py
@@ -3,7 +3,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-'''Generates a list of runtime Blimp Engine runtime dependencies.
+'''Generates a list of Blimp engine target runtime dependencies.
 '''
 
 
@@ -31,6 +31,9 @@ def main():
                       help=('name and path of manifest file to create'),
                       required=True,
                       metavar='FILE')
+  parser.add_argument('--blacklist',
+                      help=('name and path of the blacklist file to use'),
+                      required=True)
   args = parser.parse_args()
 
   try:
@@ -48,14 +51,13 @@ def main():
       '# This file was generated by running:',
       '# ' + command_line + '',
       '#',
-      '# Note: Any unnecessary dependencies should be added to',
-      '#       manifest-blacklist.txt and this file should be regenerated.',
+      '# Note: Any unnecessary dependencies should be added to provided',
+      '#       manifest-blacklist and this file should be regenerated.',
       '',
   ]
 
   blacklist_patterns = []
-  with open(os.path.join(os.sys.path[0], 'manifest-blacklist.txt'), 'r') \
-      as blacklist_file:
+  with open(args.blacklist, 'r') as blacklist_file:

[nyquist, 2016/05/05 22:31:49]

os.sys.path[0] is the script path. Does removing that always imply a path
relative to the script? I would have thought it would at that point be relative
to the current working directory?
I guess that in fact might be what we want going forward though.

[Jess, 2016/05/09 23:42:55]

My thought was to ensure that path behavior was consistent between --output and
--blacklist. Right now they are both relative to current working directory.

     blacklist_patterns = \
         [entry.partition('#')[0].strip() for entry \
          in blacklist_file.readlines()]