blimp/tools/engine-manifest-blacklist.txt - Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/tools/engine-manifest-blacklist.txt

Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing on new BUILD.gn updates. Addressing naming comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Listing of filename patterns to be excluded from the Blimp Docker manifest.	1 # Listing of filename patterns to be excluded from the Blimp Docker manifest.

2 # Wildcards (* or ?) are allowed.	2 # Wildcards (* or ?) are allowed.

3	3

	4 */manifest.json

4 *.mojo	5 *.mojo

5 *mojom.js	6 *mojom.js

	7 /mus_app_resources_.pak

6 ./libfont_service_library.so	8 ./libfont_service_library.so

7 ./libtracing_library.so	9 ./libtracing_library.so

8 ./libmus_library.so	10 ./libmus_library.so

9 ./libosmesa.so	11 ./libosmesa.so

10 ./libresource_provider_library.so	12 ./libresource_provider_library.so

11 ./mojo_runner	13 ./mojo_runner

12 snapshot_blob.bin	14 snapshot_blob.bin

	15 Mojo
	Dirk Pranke 2016/05/18 01:28:03 This last line is odd. I think you're seeing a bun This last line is odd. I think you're seeing a bunch of "Mojo Application/" stuff, and it probably makes sense to blacklist that, but shouldn't you need a wildcard here or something? Jess* 2016/05/18 17:36:44 This no longer appears to be needed. I think ther Show quoted text On 2016/05/18 01:28:03, Dirk Pranke wrote: > This last line is odd. I think you're seeing a bunch of "Mojo Application/*" > stuff, and it probably makes sense to blacklist that, but shouldn't you need a > wildcard here or something? This no longer appears to be needed. I think there was a bug in earlier version of the script where the whitespace in Mojo Application path was resulting in a split where just "Mojo" was appearing in the manifest. This is no longer occuring.
OLD	NEW

« blimp/docs/container.md ('K') | « blimp/engine/BUILD.gn ('k') | blimp/tools/generate-engine-manifest.py » ('j') | no next file with comments »