Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: blimp/docs/container.md

Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up to take from sanity check to review ready code. Includes updating blacklist. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | blimp/engine/engine-manifest.txt » ('j') | blimp/tools/generate-manifest.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Running the engine in a Docker container 1 # Running the engine in a Docker container
2 2
3 For local development and testing, you can run the engine in a Docker 3 For local development and testing, you can run the engine in a Docker
4 container. 4 container.
5 5
6 The steps are: 6 The steps are:
7 7
8 1. Bundle the engine and its dependencies. 8 1. Bundle the engine and its dependencies.
9 9
10 1. Build a Docker image. 10 1. Build a Docker image.
(...skipping 21 matching lines...) Expand all
32 ## Bundle Engine 32 ## Bundle Engine
33 33
34 The `blimp/engine:blimp_engine_bundle` build target will bundle the engine and 34 The `blimp/engine:blimp_engine_bundle` build target will bundle the engine and
35 its dependencies into a tarfile, which can be used to build a Docker image. 35 its dependencies into a tarfile, which can be used to build a Docker image.
36 This target is always built as part of the top-level `blimp/blimp` meta-target. 36 This target is always built as part of the top-level `blimp/blimp` meta-target.
37 37
38 ### Update Engine Dependencies 38 ### Update Engine Dependencies
39 39
40 `blimp/engine/engine-manifest.txt` is a list of the engine's runtime 40 `blimp/engine/engine-manifest.txt` is a list of the engine's runtime
41 dependencies. From time to time, this list may need to be updated. Use 41 dependencies. From time to time, this list may need to be updated. Use
42 `blimp/tools/generate-engine-manifest.py` to (re)generate the manifest: 42 `blimp/tools/generate-manifest.py` to (re)generate the manifest:
43 43
44 ```bash 44 ```bash
45 ./blimp/tools/generate-engine-manifest.py \ 45 ./blimp/tools/generate-manifest.py \
46 --build-dir out-linux/Debug \ 46 --build-dir out-linux/Debug \
47 --target //blimp/engine \ 47 --target //blimp/engine \
48 --output blimp/engine/engine-manifest.txt 48 --output blimp/engine/engine-manifest.txt \
49 --blacklist blimp/tools/manifest-blacklist.txt
49 ``` 50 ```
50 51
51 Be sure to review the generated manifest and remove any false runtime 52 Be sure to review the generated manifest and remove any false runtime
52 dependencies. 53 dependencies.
53 54
54 For all entries listed in the manifest that are not from 55 For all entries listed in the manifest that are not from
55 `//third_party/blimp_fonts`, ensure that the target that generate that artifact 56 `//third_party/blimp_fonts`, ensure that the target that generate that artifact
56 is manually listed as a dependency of `//blimp/engine:blimp_engine_bundle` to 57 is manually listed as a dependency of `//blimp/engine:blimp_engine_bundle` to
57 ensure that it is built before the bundle step happens. 58 ensure that it is built before the bundle step happens.
58 59
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 ```bash 94 ```bash
94 docker run -v $CONFIG_DIR:/engine/data -p 443:25466 blimp_engine 95 docker run -v $CONFIG_DIR:/engine/data -p 443:25466 blimp_engine
95 ``` 96 ```
96 You can also pass additional flags: 97 You can also pass additional flags:
97 98
98 ```bash 99 ```bash
99 docker run ... blimp_engine --with-my-flags 100 docker run ... blimp_engine --with-my-flags
100 ``` 101 ```
101 See the [blimp engine `Dockerfile`](../engine/Dockerfile) to find out what flags 102 See the [blimp engine `Dockerfile`](../engine/Dockerfile) to find out what flags
102 are passed by default. 103 are passed by default.
OLDNEW
« no previous file with comments | « no previous file | blimp/engine/engine-manifest.txt » ('j') | blimp/tools/generate-manifest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698