blimp/engine/engine-manifest.txt - Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument.

Side by Side Diff: blimp/engine/engine-manifest.txt

Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Runtime dependencies for the Blimp Engine	1 # Runtime dependencies for the Blimp Engine

2 #	2 #

3 # This file was generated by running:	3 # This file was generated by running:

4 # generate-engine-manifest.py --build-dir out-chromeos/Debug --target //blimp/en gine --output blimp/engine/engine-manifest.txt	4 # generate-engine-manifest.py --build-dir out-linux/Debug --target //blimp/engin e --output blimp/engine/engine-manifest.txt --blacklist blimp/tools/manifest-bla cklist.txt

5 #	5 #

6 # Note: Any unnecessary dependencies should be added to	6 # Note: Any unnecessary dependencies should be added to provided

7 # manifest-blacklist.txt and this file should be regenerated.	7 # manifest-blacklist and this file should be regenerated.

	8 Mojo

	9 Applications/media/manifest.json

	10 Mojo

	11 Applications/user/manifest.json

8 ./blimp_engine_app	12 ./blimp_engine_app

9 icudtl.dat	13 icudtl.dat

	14 Mojo

	15 Applications/catalog/manifest.json

	16 Mojo

	17 Applications/shell/manifest.json

10 natives_blob.bin	18 natives_blob.bin

	19 Mojo

	20 Mojo
	maniscalco 2016/05/03 21:57:54 Mojo is repeated several times... something seems Mojo is repeated several times... something seems odd here. Looks like the generation of the manifest isn't working properly anymore (this is probably why some of the trybots are failing). Might be best to not regen the manifest as part of this change. Or maybe add these new items to the blacklist? nyquist 2016/05/03 22:44:59 I don't think our bundle needs these. Could you ju Show quoted text On 2016/05/03 21:57:54, maniscalco wrote: > Mojo is repeated several times... something seems odd here. Looks like the > generation of the manifest isn't working properly anymore (this is probably why > some of the trybots are failing). Might be best to not regen the manifest as > part of this change. Or maybe add these new items to the blacklist? I don't think our bundle needs these. Could you just add /manifest.json to the blacklist? The same with "Mojo". There is some wildcard-support in the blacklist, but just verify that none of these new dependencies sneak in. Jess* 2016/05/09 23:42:55 Agree this behavior is odd which is why I included Show quoted text On 2016/05/03 21:57:54, maniscalco wrote: > Mojo is repeated several times... something seems odd here. Looks like the > generation of the manifest isn't working properly anymore (this is probably why > some of the trybots are failing). Might be best to not regen the manifest as > part of this change. Or maybe add these new items to the blacklist? Agree this behavior is odd which is why I included these changes. From comments it appears the blacklist should be updated. That change and resulting engine manifest are reflected in patch set 2. Jess 2016/05/09 23:42:55 Acknowledged. Show quoted text On 2016/05/03 22:44:59, nyquist wrote: > On 2016/05/03 21:57:54, maniscalco wrote: > > Mojo is repeated several times... something seems odd here. Looks like the > > generation of the manifest isn't working properly anymore (this is probably > why > > some of the trybots are failing). Might be best to not regen the manifest as > > part of this change. Or maybe add these new items to the blacklist? > > I don't think our bundle needs these. Could you just add */manifest.json to the > blacklist? The same with "Mojo". > > There is some wildcard-support in the blacklist, but just verify that none of > these new dependencies sneak in. Acknowledged.
	21 Mojo

	22 Mojo

	23 Applications/tracing/manifest.json

	24 Mojo

	25 Applications/resource_provider/manifest.json

	26 Mojo

	27 Applications/mus/manifest.json

	28 Mojo

	29 Applications/mus/resources/mus_app_resources_strings.pak

	30 Mojo

	31 Applications/mus/resources/mus_app_resources_100.pak

	32 Mojo

	33 Applications/mus/resources/mus_app_resources_200.pak

	34 Mojo

	35 Mojo

	36 Applications/font_service/manifest.json

11 blimp_engine.pak	37 blimp_engine.pak

12 ./chrome_sandbox	38 ./chrome_sandbox

13 gen/third_party/blimp_fonts/LICENSE	39 gen/third_party/blimp_fonts/LICENSE

14 gen/third_party/blimp_fonts/LICENSE.Apache	40 gen/third_party/blimp_fonts/LICENSE.Apache

15 gen/third_party/blimp_fonts/LICENSE.OFL	41 gen/third_party/blimp_fonts/LICENSE.OFL

16 gen/third_party/blimp_fonts/AndroidClock.ttf	42 gen/third_party/blimp_fonts/AndroidClock.ttf

17 gen/third_party/blimp_fonts/AndroidClock_Highlight.ttf	43 gen/third_party/blimp_fonts/AndroidClock_Highlight.ttf

18 gen/third_party/blimp_fonts/AndroidClock_Solid.ttf	44 gen/third_party/blimp_fonts/AndroidClock_Solid.ttf

19 gen/third_party/blimp_fonts/CarroisGothicSC-Regular.ttf	45 gen/third_party/blimp_fonts/CarroisGothicSC-Regular.ttf

20 gen/third_party/blimp_fonts/Clockopia.ttf	46 gen/third_party/blimp_fonts/Clockopia.ttf

(...skipping 186 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
207 gen/third_party/blimp_fonts/Roboto-MediumItalic.ttf	233 gen/third_party/blimp_fonts/Roboto-MediumItalic.ttf

208 gen/third_party/blimp_fonts/Roboto-Regular.ttf	234 gen/third_party/blimp_fonts/Roboto-Regular.ttf

209 gen/third_party/blimp_fonts/Roboto-Thin.ttf	235 gen/third_party/blimp_fonts/Roboto-Thin.ttf

210 gen/third_party/blimp_fonts/Roboto-ThinItalic.ttf	236 gen/third_party/blimp_fonts/Roboto-ThinItalic.ttf

211 gen/third_party/blimp_fonts/RobotoCondensed-Bold.ttf	237 gen/third_party/blimp_fonts/RobotoCondensed-Bold.ttf

212 gen/third_party/blimp_fonts/RobotoCondensed-BoldItalic.ttf	238 gen/third_party/blimp_fonts/RobotoCondensed-BoldItalic.ttf

213 gen/third_party/blimp_fonts/RobotoCondensed-Italic.ttf	239 gen/third_party/blimp_fonts/RobotoCondensed-Italic.ttf

214 gen/third_party/blimp_fonts/RobotoCondensed-Light.ttf	240 gen/third_party/blimp_fonts/RobotoCondensed-Light.ttf

215 gen/third_party/blimp_fonts/RobotoCondensed-LightItalic.ttf	241 gen/third_party/blimp_fonts/RobotoCondensed-LightItalic.ttf

216 gen/third_party/blimp_fonts/RobotoCondensed-Regular.ttf	242 gen/third_party/blimp_fonts/RobotoCondensed-Regular.ttf

217 gen/third_party/blimp_fonts/fonts.xml	243 gen/third_party/blimp_fonts/fonts.xml

OLD	NEW

« no previous file with comments | « blimp/docs/container.md ('k') | blimp/tools/generate-engine-manifest.py » ('j') | blimp/tools/generate-engine-manifest.py » ('J')