Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: tests/PathOpsDLineTest.cpp

Issue 19374003: harden and speed up path op unit tests (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: rename threaded to single Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/PathOpsDCubicTest.cpp ('k') | tests/PathOpsDPointTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PathOpsDLineTest.cpp
diff --git a/tests/PathOpsDLineTest.cpp b/tests/PathOpsDLineTest.cpp
index c23749416225d548c121c09b123e141b552b932b..feab21d4668939b0ec6d7d45c0ced6db739d9563 100644
--- a/tests/PathOpsDLineTest.cpp
+++ b/tests/PathOpsDLineTest.cpp
@@ -4,6 +4,7 @@
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
+#include "PathOpsTestCommon.h"
#include "SkPathOpsLine.h"
#include "Test.h"
@@ -30,11 +31,13 @@ static const size_t tests_count = SK_ARRAY_COUNT(tests);
static void PathOpsLineUtilitiesTest(skiatest::Reporter* reporter) {
for (size_t index = 0; index < tests_count; ++index) {
const SkDLine& line = tests[index];
+ SkASSERT(ValidLine(line));
SkDLine line2;
SkPoint pts[2] = {line[0].asSkPoint(), line[1].asSkPoint()};
line2.set(pts);
REPORTER_ASSERT(reporter, line[0] == line2[0] && line[1] == line2[1]);
const SkDPoint& pt = left[index];
+ SkASSERT(ValidPoint(pt));
double result = line.isLeft(pt);
if ((result <= 0 && index >= 1) || (result < 0 && index == 0)) {
SkDebugf("%s [%d] expected left\n", __FUNCTION__, index);
« no previous file with comments | « tests/PathOpsDCubicTest.cpp ('k') | tests/PathOpsDPointTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698