Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 19374003: harden and speed up path op unit tests (Closed)

Created:
7 years, 5 months ago by caryclark
Modified:
7 years, 5 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

harden and speed up path op unit tests PathOps tests internal routines direcctly. Check to make sure that test points, lines, quads, curves, triangles, and bounds read from arrays are valid (i.e., don't contain NaN) before calling the test function. Repurpose the test flags. - make 'v' verbose test region output against path output - make 'z' single threaded (before it made it multithreaded) The latter change speeds up tests run by the buildbot by 2x to 3x. BUG= Committed: https://code.google.com/p/skia/source/detail?r=10107

Patch Set 1 #

Patch Set 2 : rename threaded to single #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -105 lines) Patch
M tests/PathOpsAngleTest.cpp View 4 chunks +7 lines, -0 lines 0 comments Download
M tests/PathOpsBoundsTest.cpp View 3 chunks +7 lines, -0 lines 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/PathOpsCubicQuadIntersectionTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/PathOpsCubicReduceOrderTest.cpp View 12 chunks +12 lines, -0 lines 0 comments Download
M tests/PathOpsCubicToQuadsTest.cpp View 5 chunks +5 lines, -0 lines 0 comments Download
M tests/PathOpsDCubicTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/PathOpsDLineTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/PathOpsDPointTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/PathOpsDQuadTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/PathOpsDRectTest.cpp View 4 chunks +4 lines, -0 lines 0 comments Download
M tests/PathOpsDTriangleTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/PathOpsDVectorTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 5 chunks +16 lines, -4 lines 0 comments Download
M tests/PathOpsLineIntersectionTest.cpp View 3 chunks +5 lines, -0 lines 0 comments Download
M tests/PathOpsLineParametetersTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/PathOpsOpCubicThreadedTest.cpp View 2 chunks +25 lines, -18 lines 0 comments Download
M tests/PathOpsOpRectThreadedTest.cpp View 1 chunk +25 lines, -18 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 4 chunks +7 lines, -0 lines 0 comments Download
M tests/PathOpsQuadLineIntersectionTest.cpp View 3 chunks +5 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyDegenerateThreadedTest.cpp View 2 chunks +19 lines, -12 lines 0 comments Download
M tests/PathOpsSimplifyQuadThreadedTest.cpp View 2 chunks +20 lines, -13 lines 0 comments Download
M tests/PathOpsSimplifyQuadralateralsThreadedTest.cpp View 2 chunks +22 lines, -15 lines 0 comments Download
M tests/PathOpsSimplifyRectThreadedTest.cpp View 5 chunks +26 lines, -11 lines 0 comments Download
M tests/PathOpsSimplifyTrianglesThreadedTest.cpp View 2 chunks +19 lines, -12 lines 0 comments Download
M tests/PathOpsTestCommon.h View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/PathOpsTestCommon.cpp View 2 chunks +83 lines, -0 lines 0 comments Download
M tests/Test.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/skia_test.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
caryclark
7 years, 5 months ago (2013-07-16 16:11:34 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r10107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698