Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

Issue 1937313003: Hide WebGraphicsContext3DCommandBufferImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: construct: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
index 274b173097af6221a6a3f735a74fbf11ed871e69..dfd06f1f25289c4aec527246116894374866ed17 100644
--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
@@ -54,13 +54,7 @@ class WebGraphicsContext3DCommandBufferImpl {
// the associated window must not be destroyed until the returned
// CommandBufferProxy has been destroyed, otherwise the GPU process might
// attempt to render to an invalid window handle.
- CONTENT_EXPORT WebGraphicsContext3DCommandBufferImpl(
- gpu::SurfaceHandle surface_handle,
- const GURL& active_url,
- scoped_refptr<gpu::GpuChannelHost> host,
- gfx::GpuPreference gpu_preference,
- bool automatic_flushes);
-
+ CONTENT_EXPORT WebGraphicsContext3DCommandBufferImpl();
CONTENT_EXPORT ~WebGraphicsContext3DCommandBufferImpl();
gpu::CommandBufferProxyImpl* GetCommandBufferProxy() {
@@ -72,6 +66,11 @@ class WebGraphicsContext3DCommandBufferImpl {
}
CONTENT_EXPORT bool InitializeOnCurrentThread(
+ gpu::SurfaceHandle surface_handle,
+ const GURL& active_url,
+ gpu::GpuChannelHost* host,
+ gfx::GpuPreference gpu_preference,
+ bool automatic_flushes,
const gpu::SharedMemoryLimits& memory_limits,
gpu::CommandBufferProxyImpl* shared_command_buffer,
scoped_refptr<gpu::gles2::ShareGroup> share_group,
@@ -80,18 +79,17 @@ class WebGraphicsContext3DCommandBufferImpl {
private:
bool MaybeInitializeGL(
+ gpu::SurfaceHandle surface_handle,
+ const GURL& active_url,
+ gpu::GpuChannelHost* host,
+ gfx::GpuPreference gpu_preference,
+ bool automatic_flushes,
const gpu::SharedMemoryLimits& memory_limits,
gpu::CommandBufferProxyImpl* shared_command_buffer,
scoped_refptr<gpu::gles2::ShareGroup> share_group,
const gpu::gles2::ContextCreationAttribHelper& attributes,
command_buffer_metrics::ContextType context_type);
- bool automatic_flushes_;
- gpu::SurfaceHandle surface_handle_;
- GURL active_url_;
- gfx::GpuPreference gpu_preference_;
-
- scoped_refptr<gpu::GpuChannelHost> host_;
std::unique_ptr<gpu::CommandBufferProxyImpl> command_buffer_;
std::unique_ptr<gpu::gles2::GLES2CmdHelper> gles2_helper_;
std::unique_ptr<gpu::TransferBuffer> transfer_buffer_;

Powered by Google App Engine
This is Rietveld 408576698