Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1937303003: Set layers needsRepaint along the original compositingContainer chain if stacking status changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 1316 matching lines...) Expand 10 before | Expand all | Expand 10 after
1327 curr->moveLayers(m_parent, this); 1327 curr->moveLayers(m_parent, this);
1328 1328
1329 // If the previous paint invalidation container is not a stacking context an d this object is 1329 // If the previous paint invalidation container is not a stacking context an d this object is
1330 // stacked content, creating this layer may cause this object and its descen dants to change 1330 // stacked content, creating this layer may cause this object and its descen dants to change
1331 // paint invalidation container. 1331 // paint invalidation container.
1332 bool didSetPaintInvalidation = false; 1332 bool didSetPaintInvalidation = false;
1333 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() && !layoutObject()->is LayoutView() && layoutObject()->isRooted() && layoutObject()->styleRef().isStack ed()) { 1333 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() && !layoutObject()->is LayoutView() && layoutObject()->isRooted() && layoutObject()->styleRef().isStack ed()) {
1334 const LayoutBoxModelObject& previousPaintInvalidationContainer = layoutO bject()->parent()->containerForPaintInvalidation(); 1334 const LayoutBoxModelObject& previousPaintInvalidationContainer = layoutO bject()->parent()->containerForPaintInvalidation();
1335 if (!previousPaintInvalidationContainer.styleRef().isStackingContext()) { 1335 if (!previousPaintInvalidationContainer.styleRef().isStackingContext()) {
1336 layoutObject()->invalidatePaintIncludingNonSelfPaintingLayerDescenda nts(previousPaintInvalidationContainer); 1336 layoutObject()->invalidatePaintIncludingNonSelfPaintingLayerDescenda nts(previousPaintInvalidationContainer);
1337 // Set needsRepaint along the original compositingContainer chain.
1338 layoutObject()->parent()->enclosingLayer()->setNeedsRepaint();
1337 didSetPaintInvalidation = true; 1339 didSetPaintInvalidation = true;
1338 } 1340 }
1339 } 1341 }
1340 1342
1341 if (!didSetPaintInvalidation && isSelfPaintingLayer() && m_parent) { 1343 if (!didSetPaintInvalidation && isSelfPaintingLayer() && m_parent) {
1342 if (PaintLayer* enclosingSelfPaintingLayer = m_parent->enclosingSelfPain tingLayer()) 1344 if (PaintLayer* enclosingSelfPaintingLayer = m_parent->enclosingSelfPain tingLayer())
1343 mergeNeedsPaintPhaseFlagsFrom(*enclosingSelfPaintingLayer); 1345 mergeNeedsPaintPhaseFlagsFrom(*enclosingSelfPaintingLayer);
1344 } 1346 }
1345 1347
1346 // Clear out all the clip rects. 1348 // Clear out all the clip rects.
(...skipping 1564 matching lines...) Expand 10 before | Expand all | Expand 10 after
2911 2913
2912 void showLayerTree(const blink::LayoutObject* layoutObject) 2914 void showLayerTree(const blink::LayoutObject* layoutObject)
2913 { 2915 {
2914 if (!layoutObject) { 2916 if (!layoutObject) {
2915 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 2917 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
2916 return; 2918 return;
2917 } 2919 }
2918 showLayerTree(layoutObject->enclosingLayer()); 2920 showLayerTree(layoutObject->enclosingLayer());
2919 } 2921 }
2920 #endif 2922 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698