Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

Issue 1937253002: DevTools: fix user agent custom behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
index 4542502e4721cf9fec8345c8602731893fdece0e..cca0d3fa288279dd89e2d1db10d7ad82690950c3 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
@@ -126,7 +126,7 @@ WebInspector.NetworkConfigView.createUserAgentSelectAndInput = function()
otherUserAgentElement.value = value;
otherUserAgentElement.title = value;
} else {
- otherUserAgentElement.focus();
+ otherUserAgentElement.select();
}
}
@@ -146,10 +146,11 @@ WebInspector.NetworkConfigView.createUserAgentSelectAndInput = function()
if (!selectionRestored)
userAgentSelectElement.selectedIndex = 0;
- if (otherUserAgentElement.value !== value) {
+ if (otherUserAgentElement.value !== value)
otherUserAgentElement.value = value;
+
+ if (otherUserAgentElement.title !== value)
lushnikov 2016/05/02 18:48:55 how does this fix the bug?
luoe 2016/05/02 19:11:26 textChanged() updates the value of the input field
otherUserAgentElement.title = value;
- }
}
function textChanged()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698