DevTools: fix user agent custom behavior

DevTools: fix user agent custom behavior

BUG=550362
Committed: https://crrev.com/8afd18b720250bec88cce6d0680b2f93d1fc88e1
Cr-Commit-Position: refs/heads/master@{#391079}

[luoe, 2016-05-02 18:13:32]

Description was changed from

==========
DevTools: fix user agent custom bbehavior

BUG=550362
==========

to

==========
DevTools: fix user agent custom behavior

BUG=550362
==========

[luoe, 2016-05-02 18:13:32]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2016-05-02 18:48:55]

https://codereview.chromium.org/1937253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
(right):

https://codereview.chromium.org/1937253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js:152:
if (otherUserAgentElement.title !== value)
how does this fix the bug?

[luoe, 2016-05-02 19:11:26]

The if statement in settingsChanged() wasn't actually necessary, because
whenever settingsChanged() is called, the userAgentSetting value is always equal
to the input field's value.

I updated textChanged() to update the title right after the value is changed.

https://codereview.chromium.org/1937253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
(right):

https://codereview.chromium.org/1937253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js:152:
if (otherUserAgentElement.title !== value)
On 2016/05/02 18:48:55, lushnikov wrote:
> how does this fix the bug?

textChanged() updates the value of the input field without updating it's title. 
Actually, (textChanged) that's where we should be setting the title.

[lushnikov, 2016-05-02 19:13:47]

thanks, lgtm

[luoe, 2016-05-02 20:46:16]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-05-02 20:46:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1937253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1937253002/20001

[commit-bot: I haz the power, 2016-05-02 22:35:14]

Description was changed from

==========
DevTools: fix user agent custom behavior

BUG=550362
==========

to

==========
DevTools: fix user agent custom behavior

BUG=550362
==========

[commit-bot: I haz the power, 2016-05-02 22:35:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-02 22:37:48]

Description was changed from

==========
DevTools: fix user agent custom behavior

BUG=550362
==========

to

==========
DevTools: fix user agent custom behavior

BUG=550362

Committed: https://crrev.com/8afd18b720250bec88cce6d0680b2f93d1fc88e1
Cr-Commit-Position: refs/heads/master@{#391079}
==========

[commit-bot: I haz the power, 2016-05-02 22:37:49]

Patchset 2 (id:??) landed as
https://crrev.com/8afd18b720250bec88cce6d0680b2f93d1fc88e1
Cr-Commit-Position: refs/heads/master@{#391079}